Message-ID: <7d75e12a4eb373a5a7e90161049a0eccb6b8c63c.camel@perches.com>
Subject: Re: [PATCH net-next] net: lantiq_etop: make alignment match open
 parenthesis
From:   Joe Perches <joe@perches.com>
To:     Aleksander Jan Bajkowski <olek2@wp.pl>, davem@davemloft.net,
        kuba@kernel.org, jgg@ziepe.ca, rdunlap@infradead.org,
        arnd@arndb.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Wed, 29 Dec 2021 17:32:49 -0800
In-Reply-To: <20211229233952.5306-1-olek2@wp.pl>
References: <20211229233952.5306-1-olek2@wp.pl>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.40.4-1ubuntu2 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu, 2021-12-30 at 00:39 +0100, Aleksander Jan Bajkowski wrote:
> checkpatch.pl complains as the following:
> 
> Alignment should match open parenthesis
[]
> diff --git a/drivers/net/ethernet/lantiq_etop.c b/drivers/net/ethernet/lantiq_etop.c
[]
> @@ -111,9 +111,9 @@ ltq_etop_alloc_skb(struct ltq_etop_chan *ch)
>  	ch->skb[ch->dma.desc] = netdev_alloc_skb(ch->netdev, MAX_DMA_DATA_LEN);
>  	if (!ch->skb[ch->dma.desc])
>  		return -ENOMEM;
> -	ch->dma.desc_base[ch->dma.desc].addr = dma_map_single(&priv->pdev->dev,
> -		ch->skb[ch->dma.desc]->data, MAX_DMA_DATA_LEN,
> -		DMA_FROM_DEVICE);
> +	ch->dma.desc_base[ch->dma.desc].addr =
> +		dma_map_single(&priv->pdev->dev, ch->skb[ch->dma.desc]->data,
> +			       MAX_DMA_DATA_LEN, DMA_FROM_DEVICE);
>  	ch->dma.desc_base[ch->dma.desc].addr =
>  		CPHYSADDR(ch->skb[ch->dma.desc]->data);

Unassociated trivia:

ch->dma.desc_base[ch->dma.desc].addr is the target of consecutive assignments.

That looks very odd.

Isn't the compiler allowed to toss/throw away the first assignment?