User-Agent: Microsoft-MacOutlook/16.56.21121100
Date:   Thu, 30 Dec 2021 11:26:31 +0800
Subject: [Resource Leak] Missing closing files in samples/bpf/hbm.c
From:   Ryan Cai <ycaibb@gmail.com>
To:     <ast@kernel.org>, <daniel@iogearbox.net>, <andrii@kernel.org>,
        <kafai@fb.com>, <songliubraving@fb.com>, <yhs@fb.com>,
        <john.fastabend@gmail.com>, <kpsingh@kernel.org>
CC:     <netdev@vger.kernel.org>, <bpf@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Message-ID: <BCA4C02F-0238-4818-BDF1-2F0411CD95A6@gmail.com>
Thread-Topic: [Resource Leak] Missing closing files in samples/bpf/hbm.c
Mime-version: 1.0
Content-type: text/plain;
        charset="UTF-8"
Content-transfer-encoding: 7bit
Precedence: bulk

Dear Kernel maintainers,

          1. In run_bpf_prog, the file opened at Line 308 may not closed when going to Line 310.
          Location: https://github.com/torvalds/linux/blob/5bfc75d92efd494db37f5c4c173d3639d4772966/samples/bpf/hbm.c#L302-L310

         2. In read_trace_pipe2, the file opened at Line 91 may not closed in the function.
         Location: https://github.com/torvalds/linux/blob/5bfc75d92efd494db37f5c4c173d3639d4772966/samples/bpf/hbm.c#L91-L109

           Should it be a bug? I can send a patch for these.

Best,
Ryan