Date:   Wed, 29 Dec 2021 19:51:35 -0800
From:   Andrew Morton <akpm@linux-foundation.org>
To:     Ryan Cai <ycaibb@gmail.com>
Cc:     <shuah@kernel.org>, <linux-mm@kvack.org>,
        <linux-kselftest@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [Resource Leak] Missing closing files in
 testing/selftests/vm/mlock2
Message-Id: <20211229195135.959b3730c54652de497e932b@linux-foundation.org>
In-Reply-To: <C8980E43-5BED-45C6-B3F8-7BC3D58DF21A@gmail.com>
References: <C8980E43-5BED-45C6-B3F8-7BC3D58DF21A@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, 30 Dec 2021 11:17:37 +0800 Ryan Cai <ycaibb@gmail.com> wrote:

> Dear Kernel maintainers,
>              =A01. In testing/selftests/vm/mlock2, the file opened at Lin=
e 39 may not closed when going to Line 65.
>               Location: https://github.com/torvalds/linux/blob/5bfc75d92e=
fd494db37f5c4c173d3639d4772966/tools/testing/selftests/vm/mlock2.h#L37-L49

That's what exit() does.  I don't think we really care unless the leak
is inside a loop.

That being said, it's untidy and is setting a poor example so I guess
we should fix it.

>               Can I send I a patch?

It would be better to just send the patch rather than preceding it
with "can I send a patch".  Everyone can send a patch and they are
encouraged to do so!