Subject: Re: [PATCH -next 0/2] riscv/mm: Enable THP migration
To:     <paul.walmsley@sifive.com>, <palmer@dabbelt.com>,
        <aou@eecs.berkeley.edu>
CC:     <palmerdabbelt@google.com>, <wangkefeng.wang@huawei.com>,
        <anup@brainfault.org>, <alex@ghiti.fr>, <jszhang@kernel.org>,
        <linux-riscv@lists.infradead.org>, <linux-kernel@vger.kernel.org>
References: <20211123140638.3852400-1-sunnanyong@huawei.com>
From:   Nanyong Sun <sunnanyong@huawei.com>
Message-ID: <3c9ba160-74b2-a933-e8e5-9fd5359dc2cc@huawei.com>
Date:   Thu, 30 Dec 2021 14:45:57 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <20211123140638.3852400-1-sunnanyong@huawei.com>
Content-Type: text/plain; charset="gbk"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Palmer,

This patchset has been sent for one month ago, I was wondering if you could

have a review and give a feedback please, thanks.

On 2021/11/23 22:06, Nanyong Sun wrote:
> This series enables THP migration on riscv via ARCH_ENABLE_THP_MIGRATION.
> But first this adjusts PAGE_PROT_NONE to satisfy generic memory semantics
> like the behavior of pmd_present() and pmd_trans_huge() when in
> THP splitting or migration.
>
> This feature can reduce the time of THP migration by not splits THP
> before migration and can guarantee the pages after migration are still
> contiguous.[1]
>
> I have tested the below test case on qemu based on riscv after
> enabling this feature, the throughput of THP migration gains 13x
> performance improvement:
> https://github.com/x-y-z/thp-migration-bench
>
> I also have tested and passed the test cases under
> tools/testing/selftests/vm.
>
> [1]: https://lwn.net/Articles/723764/
>
> Nanyong Sun (2):
>    riscv/mm: Adjust PAGE_PROT_NONE to comply with THP semantics
>    riscv/mm: Enable THP migration
>
>   arch/riscv/Kconfig                    |  1 +
>   arch/riscv/include/asm/pgtable-bits.h |  2 +-
>   arch/riscv/include/asm/pgtable.h      | 16 +++++++++++-----
>   3 files changed, 13 insertions(+), 6 deletions(-)
>