Message-ID: <ca006060-10d8-bdd4-0824-943750542f61@linux.alibaba.com>
Date:   Thu, 30 Dec 2021 15:26:30 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.1
Subject: Re: [PATCH] lib/mpi: Add the return value check of kcalloc()
Content-Language: en-US
To:     Zizhuang Deng <sunsetdzz@gmail.com>, herbert@gondor.apana.org.au
Cc:     linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org
References: <20211230070331.1046343-1-sunsetdzz@gmail.com>
From:   Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
In-Reply-To: <20211230070331.1046343-1-sunsetdzz@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 12/30/21 3:03 PM, Zizhuang Deng wrote:
> Add the return value check of kcalloc() to avoid potential
> NULL ptr dereference.
> 
> Signed-off-by: Zizhuang Deng <sunsetdzz@gmail.com>
> ---

Reviewed-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>

Best regards,
Tianjia

>   lib/mpi/mpi-mod.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/lib/mpi/mpi-mod.c b/lib/mpi/mpi-mod.c
> index 47bc59edd4ff..54fcc01564d9 100644
> --- a/lib/mpi/mpi-mod.c
> +++ b/lib/mpi/mpi-mod.c
> @@ -40,6 +40,8 @@ mpi_barrett_t mpi_barrett_init(MPI m, int copy)
>   
>   	mpi_normalize(m);
>   	ctx = kcalloc(1, sizeof(*ctx), GFP_KERNEL);
> +	if (!ctx)
> +		return NULL;
>   
>   	if (copy) {
>   		ctx->m = mpi_copy(m);