Date:   Thu, 30 Dec 2021 13:12:26 +0100
From:   Florian Westphal <fw@strlen.de>
To:     cgel.zte@gmail.com
Cc:     Pablo Neira Ayuso <pablo@netfilter.org>,
        Jozsef Kadlecsik <kadlec@netfilter.org>,
        Florian Westphal <fw@strlen.de>,
        Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
        David Ahern <dsahern@kernel.org>,
        Jakub Kicinski <kuba@kernel.org>,
        netfilter-devel@vger.kernel.org, linux-kernel@vger.kernel.org,
        luo penghao <luo.penghao@zte.com.cn>,
        Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH linux] netfilter: Remove unnecessary ret assignment
Message-ID: <20211230121226.GC21386@breakpoint.cc>
References: <20211230063143.586220-1-luo.penghao@zte.com.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: 8BIT
In-Reply-To: <20211230063143.586220-1-luo.penghao@zte.com.cn>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

cgel.zte@gmail.com <cgel.zte@gmail.com> wrote:
> From: luo penghao <luo.penghao@zte.com.cn>
> 
> Regardless of whether the subsequent (copy_to_user(user, &info, *len) != 0)
> holds, the value of ret will be assigned a new value.
> 
> The clang_analyzer complains as follows:
> 
> net/ipv6/netfilter/ip6_tables.c:
> 
> Value stored to 'ret' is never read

Please fix this properly:

1. consider adding error unwinding instead.
2. net/ipv4/netfilter/ip_tables.c has same construct