Date:   Fri, 31 Dec 2021 03:56:21 +1300
From:   Paulo Miguel Almeida <paulo.miguel.almeida.rodenas@gmail.com>
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     realwakka@gmail.com, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: pi433: add comment to rx_lock mutex
 definition
Message-ID: <20211230145621.GA3236@localhost.localdomain>
References: <20211222215615.GA9361@localhost.localdomain>
 <Yc2QYUcIAV2SY9JU@kroah.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Yc2QYUcIAV2SY9JU@kroah.com>
Precedence: bulk

On Thu, Dec 30, 2021 at 11:56:33AM +0100, Greg KH wrote:
> On Thu, Dec 23, 2021 at 10:56:15AM +1300, Paulo Miguel Almeida wrote:
> > +	/*
> > +	 * rx_lock is used to avoid race-conditions that can be triggered from userspace.
> > +	 *
> > +	 * For instance, if a program in userspace is reading the char device
> > +	 * allocated in this module then another program won't be able to change RX
> > +	 * configuration of the RF69 hardware module via ioctl and vice versa.
> > +	 *
> > +	 * utilization summary:
> > +	 *  - pi433_read: blocks are read until rx read something (up to the buffer size)
> > +	 *  - pi433_ioctl: during pending read request, change of config not allowed
> > +	 */
> 
> This is nice, but way too specific, and will quickly get out-of-date.
> 
> How about something simple like:
> 	/* Protects all rx_* variable accesses */
> 
I see your point. I will send a new version of this patch with your
sugestion. Thanks for guidance.

thanks,

Paulo A.