MIME-Version: 1.0
References: <20211223094236.15179-1-sumeet.r.pawnikar@intel.com> <2b55b71aaa89e9010d58f5b3c7f5823782ab760c.camel@linux.intel.com>
In-Reply-To: <2b55b71aaa89e9010d58f5b3c7f5823782ab760c.camel@linux.intel.com>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Thu, 30 Dec 2021 16:44:30 +0100
Message-ID: <CAJZ5v0hj83Bmw0-Yhb22xQHGauRWL-RADkiKQRuvcpYi3A45WA@mail.gmail.com>
Subject: Re: [PATCH v2] thermal/drivers/int340x: Fix RFIM mailbox write commands
To:     srinivas pandruvada <srinivas.pandruvada@linux.intel.com>,
        Sumeet Pawnikar <sumeet.r.pawnikar@intel.com>
Cc:     "Rafael J. Wysocki" <rafael@kernel.org>,
        Daniel Lezcano <daniel.lezcano@linaro.org>,
        Linux PM <linux-pm@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Stable <stable@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Dec 23, 2021 at 4:31 PM srinivas pandruvada
<srinivas.pandruvada@linux.intel.com> wrote:
>
> On Thu, 2021-12-23 at 15:12 +0530, Sumeet Pawnikar wrote:
> > The existing mail mechanism only supports writing of workload types.
> > But mailbox command for RFIM (cmd = 0x08) also requires write operation
> > which was ignored. This results in failing to store RFI restriction.
> > This requires enhancing mailbox writes for non workload commands also.
> > So, remove the check for MBOX_CMD_WORKLOAD_TYPE_WRITE in mailbox write,
> > with this other write commands also can be supoorted. But at the same
> > time, we have to make sure that there is no impact on read commands,
> > by not writing anything in mailbox data register.
> > To properly implement, add two separate functions for mbox read and
> > write
> > command for processor thermal workload command type. This helps to
> > differentiate the read and write workload command types while sending
> > mbox
> > command.
> >
> > Fixes: 5d6fbc96bd36 ("thermal/drivers/int340x: processor_thermal:
> > Export additional attributes")
> > Signed-off-by: Sumeet Pawnikar <sumeet.r.pawnikar@intel.com>
> > Cc: stable@vger.kernel.org # 5.14+
> Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>

Applied (with some edits in the changelog) as 5.17 material, thanks!