Date:   Fri, 31 Dec 2021 04:53:44 +1300
From:   Paulo Miguel Almeida <paulo.miguel.almeida.rodenas@gmail.com>
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: pi433: add docs to packet_format and
 tx_start_condition enum
Message-ID: <20211230155344.GA5404@localhost.localdomain>
References: <20211229094713.GA28795@localhost.localdomain>
 <Yc2QrMecuVQFRcBZ@kroah.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Yc2QrMecuVQFRcBZ@kroah.com>
Precedence: bulk

On Thu, Dec 30, 2021 at 11:57:48AM +0100, Greg KH wrote:
> > +/*
> > + * Defines the packet format used.
> 
> What "Defines"?  This is an odd sentence.

Noted. I will change that.

> > + * In both modes the length of the payload is limited to 255 bytes if AES
> > + * is not enabled or 64 bytes otherwise.
> 
> What does this have to do with the format type?
> 

The rationale was that I wanted the developer to know straight away how
much info would be possible to transfer given the combination of
encryption + packet_format settings. 

But now that you mentioned it, I can see that this info/obs could be 
misplaced. I will remove it.

> > +    /* at least one byte in the FIFO */
> >  	fifo_not_empty
> >  };
> 
> Also, always run your patches through scripts/checkpatch.pl before
> sending them out.  I couldn't take this patch for that reason alone :(
>

My apologies, I will be extra careful next time.

thanks,

Paulo A.