MIME-Version: 1.0
References: <20211222212014.66971-1-linux@weissschuh.net> <31a528b8-8318-dc09-3a06-80f76771744a@redhat.com>
In-Reply-To: <31a528b8-8318-dc09-3a06-80f76771744a@redhat.com>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Thu, 30 Dec 2021 17:29:33 +0100
Message-ID: <CAJZ5v0jdJNh4QB=-=TCKPZNYnvREPKor+mMyyUZZP8GBMn-ZFQ@mail.gmail.com>
Subject: Re: [PATCH] ACPI: battery: Add the ThinkPad "Not Charging" quirk
To:     Hans de Goede <hdegoede@redhat.com>,
        =?UTF-8?Q?Thomas_Wei=C3=9Fschuh?= <linux@weissschuh.net>
Cc:     ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
        Len Brown <lenb@kernel.org>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        ibm-acpi-devel@lists.sourceforge.net,
        Platform Driver <platform-driver-x86@vger.kernel.org>,
        Mark Pearson <markpearson@lenovo.com>,
        Andy Shevchenko <andy.shevchenko@gmail.com>,
        Ognjen Galic <smclt30p@gmail.com>,
        "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
        Bastien Nocera <hadess@hadess.net>,
        David Zeuthen <davidz@redhat.com>,
        Richard Hughes <richard@hughsie.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Thu, Dec 23, 2021 at 5:36 PM Hans de Goede <hdegoede@redhat.com> wrote:
>
> Hi Thomas,
>
> On 12/22/21 22:20, Thomas Weißschuh wrote:
> > The EC/ACPI firmware on Lenovo ThinkPads used to report a status
> > of "Unknown" when the battery is between the charge start and
> > charge stop thresholds. On Windows, it reports "Not Charging"
> > so the quirk has been added to also report correctly.
> >
> > Now the "status" attribute returns "Not Charging" when the
> > battery on ThinkPads is not physicaly charging.
> >
> > Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
>
> Thanks, patch looks good to me.
>
> As for the userspace issues in dealing with the
> POWER_SUPPLY_STATUS_NOT_CHARGING status, those indeed
> have long been fixed and this status is already returned
> acpi//battery.c from the acpi_battery_handle_discharging()
> function for a while no; and we have had no complaints
> about that:
>
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Applied as 5.17 material, thanks!