MIME-Version: 1.0
References: <20211229121605.10513-1-qianggui.song@amlogic.com> <20211229121605.10513-4-qianggui.song@amlogic.com>
In-Reply-To: <20211229121605.10513-4-qianggui.song@amlogic.com>
From:   Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Date:   Thu, 30 Dec 2021 23:09:02 +0100
Message-ID: <CAFBinCDPtiPHZ7BkTLoqpd1HiNQa1n45MeByzGHtHmK=-oOxzQ@mail.gmail.com>
Subject: Re: [PATCH v3 3/3] pinctrl: meson: add pinctrl driver support for
 Meson-S4 Soc
To:     Qianggui Song <qianggui.song@amlogic.com>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        linux-gpio@vger.kernel.org,
        Neil Armstrong <narmstrong@baylibre.com>,
        Jerome Brunet <jbrunet@baylibre.com>,
        Kevin Hilman <khilman@baylibre.com>,
        Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        linux-arm-kernel@lists.infradead.org,
        linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Dec 29, 2021 at 1:16 PM Qianggui Song <qianggui.song@amlogic.com> wrote:
>
> Add new pinctrl driver for Amlogic's Meson-S4 SoC which share the
> same register layout as the previous Meson-A1.
>
> Signed-off-by: Qianggui Song <qianggui.song@amlogic.com>
Due to lack of a datasheet to compare this with I cannot properly review this.
Instead I confirm that this generally looks good apart from two very
small nit-picks:
Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>

I suggest waiting for Jerome's review before re-sending this series.

[...]
> +static const char * const mclk_1_groups[] = {
> +       "mclk_1_c", "mclk_1_d", "mclk_1_h", "mclk_2",
> +
There's an extraneous empty line here.

[...[
> +static const char * const pwm_b_groups[] = {
> +       "pwm_b_d", "pwm_b_x",
> +
There's an extraneous empty line here.


Best regards,
Martin