MIME-Version: 1.0
References: <20211230102110.3861-1-yu.tu@amlogic.com> <20211230102110.3861-3-yu.tu@amlogic.com>
 <Yc2mHOT4WwgUrrhG@kroah.com>
In-Reply-To: <Yc2mHOT4WwgUrrhG@kroah.com>
From:   Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Date:   Thu, 30 Dec 2021 23:28:55 +0100
Message-ID: <CAFBinCBtye7KiEqFbUeNDeRGSQkhnQ-XH-Gr-KMUWYupvioP1g@mail.gmail.com>
Subject: Re: [PATCH V3 2/6] tty: serial: meson: Request the register region in meson_uart_probe()
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Yu Tu <yu.tu@amlogic.com>, linux-serial@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
        Jiri Slaby <jirislaby@kernel.org>,
        Neil Armstrong <narmstrong@baylibre.com>,
        Vyacheslav <adeep@lexina.in>,
        Kevin Hilman <khilman@baylibre.com>,
        Jerome Brunet <jbrunet@baylibre.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Greg,

On Thu, Dec 30, 2021 at 1:29 PM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
[...]
> >  static void meson_uart_release_port(struct uart_port *port)
> >  {
> > -     devm_iounmap(port->dev, port->membase);
> > -     port->membase = NULL;
> > -     devm_release_mem_region(port->dev, port->mapbase, port->mapsize);
> > +     /* nothing to do */
> >  }
>
> Are you sure a release call like this can be "empty"?  That goes against
> the normal way the driver model works.  If it is empty, why have it at
> all?
In patch #4 from this series some logic is added here again.
I can think of three options here (in no particular order):
- keep this patch as-is
- remove the empty function from this patch and it back in patch #4
from this series
- try to split some of the logic from patch #4 so the relevant
clk_prepare_enable/clk_disable_unpepare calls are added here (meaning
that this function has logic inside it at all times throughout this
series)
- (if you have another suggestion then please let us know)


Best regards,
Martin