Date:   Thu, 30 Dec 2021 18:20:59 -0800
From:   Andrew Morton <akpm@linux-foundation.org>
To:     SeongJae Park <sj@kernel.org>
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/4] Remove the type-unclear target id concept
Message-Id: <20211230182059.6535f9201eba9e420a08445a@linux-foundation.org>
In-Reply-To: <20211230100723.2238-1-sj@kernel.org>
References: <20211230100723.2238-1-sj@kernel.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu, 30 Dec 2021 10:07:19 +0000 SeongJae Park <sj@kernel.org> wrote:

> DAMON asks each monitoring target ('struct damon_target') to have one
> 'unsigned long' integer called 'id', which should be unique among the
> targets of same monitoring context.  Meaning of it is, however, totally
> up to the monitoring primitives that registered to the monitoring
> context.  For example, the virtual address spaces monitoring primitives
> treats the id as a 'struct pid' pointer.
> 
> This makes the code flexible but ugly, not well-documented, and
> type-unsafe[1].  Also, identification of each target can be done via its
> index.  For the reason, this patchset removes the concept and uses clear
> type definition.

Thanks.  This doesn't appear to be urgent, so I'll park it until after 5.17-rc1.