Message-ID: <e20e47833649b5141fa327aa8113e34d4b1bbe15.camel@codeconstruct.com.au>
Subject: Re: [PATCH] mctp: Remove only static neighbour on RTM_DELNEIGH
From:   Jeremy Kerr <jk@codeconstruct.com.au>
To:     Jakub Kicinski <kuba@kernel.org>,
        Gagan Kumar <gagan1kumar.cs@gmail.com>
Cc:     matt@codeconstruct.com.au, davem@davemloft.net,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Fri, 31 Dec 2021 11:33:00 +0800
In-Reply-To: <20211230175112.7daeb74e@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
References: <20211228130956.8553-1-gagan1kumar.cs@gmail.com>
         <20211230175112.7daeb74e@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.42.0-2 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Jakub & Gagan,

> > Add neighbour source flag in mctp_neigh_remove(...) to allow
> > removal of only static neighbours.
> 
> Which are the only ones that exist today right?

That's correct. There may be a future facility for the kernel to perform
neighbour discovery itself (somewhat analogous to ARP), but only the
static entries are possible at the moment.

> Can you clarify the motivation and practical impact of the change 
> in the commit message to make it clear? AFAICT this is a no-op / prep
> for some later changes, right Jeremy?

Yes, it'll be a no-op now; I'm not aware of any changes coming that
require parameterisation of the neighbour type yet.

Gagan - can you provide any context on this change?

Cheers,


Jeremy