Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (1.0)
Subject: Re: [PATCH] riscv: dts: sifive unmatched: Add gpio poweroff
From:   James Clarke <jrtc27@jrtc27.com>
In-Reply-To: <20211231061110.89403-1-w6rz@comcast.net>
Date:   Fri, 31 Dec 2021 06:58:22 +0000
Cc:     Dimitri John Ledkov <dimitri.ledkov@canonical.com>,
        Rob Herring <robh+dt@kernel.org>,
        Paul Walmsley <paul.walmsley@sifive.com>,
        Palmer Dabbelt <palmer@dabbelt.com>,
        Albert Ou <aou@eecs.berkeley.edu>,
        Vincent Pelletier <plr.vincent@gmail.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
        Qiu Wenbo <qiuwenbo@kylinos.com.cn>,
        Yash Shah <yash.shah@sifive.com>, devicetree@vger.kernel.org,
        linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <73F7FAE3-5113-48DD-B0F5-0EEAA0A8B0C1@jrtc27.com>
References: <20211231061110.89403-1-w6rz@comcast.net>
To:     Ron Economos <w6rz@comcast.net>
Precedence: bulk

On 31 Dec 2021, at 06:11, Ron Economos <w6rz@comcast.net> wrote:
>=20
> This patch is required for the following commit to work.
>=20
> commit f2928e224d85 ("riscv: set default pm_power_off to NULL")
>=20
> Signed-off-by: Ron Economos <w6rz@comcast.net>
> ---
> arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 5 +++++
> 1 file changed, 5 insertions(+)
>=20
> diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/ri=
scv/boot/dts/sifive/hifive-unmatched-a00.dts
> index 6bfa1f24d3de..c4ed9efdff03 100644
> --- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> +++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> @@ -39,6 +39,11 @@ rtcclk: rtcclk {
>        clock-frequency =3D <RTCCLK_FREQ>;
>        clock-output-names =3D "rtcclk";
>    };
> +
> +    gpio-poweroff {
> +        compatible =3D "gpio-poweroff";
> +        gpios =3D <&gpio 2 GPIO_ACTIVE_LOW>;
> +    };

Why? It=E2=80=99s abstracted by firmware, which works.

Jess