Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23896C433EF for ; Fri, 31 Dec 2021 10:27:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230099AbhLaK1Q (ORCPT ); Fri, 31 Dec 2021 05:27:16 -0500 Received: from mail-sh.amlogic.com ([58.32.228.43]:34146 "EHLO mail-sh.amlogic.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230084AbhLaK1O (ORCPT ); Fri, 31 Dec 2021 05:27:14 -0500 Received: from [10.18.29.173] (10.18.29.173) by mail-sh.amlogic.com (10.18.11.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Fri, 31 Dec 2021 18:27:12 +0800 Message-ID: Date: Fri, 31 Dec 2021 18:27:12 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Subject: Re: [PATCH V3 1/6] tty: serial: meson: Drop the legacy compatible strings and clock code Content-Language: en-US To: Martin Blumenstingl CC: , , , , Greg Kroah-Hartman , Jiri Slaby , Neil Armstrong , Vyacheslav , Kevin Hilman , Jerome Brunet References: <20211230102110.3861-1-yu.tu@amlogic.com> <20211230102110.3861-2-yu.tu@amlogic.com> From: Yu Tu In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.18.29.173] X-ClientProxiedBy: mail-sh.amlogic.com (10.18.11.5) To mail-sh.amlogic.com (10.18.11.5) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Martin, Thank you very much for your reply. On 2021/12/31 6:22, Martin Blumenstingl wrote: > [ EXTERNAL EMAIL ] > > On Thu, Dec 30, 2021 at 11:21 AM Yu Tu wrote: >> >> All mainline .dts files have been using the stable UART since Linux >> 4.16. Drop the legacy compatible strings and related clock code. >> >> Signed-off-by: Yu Tu > I have just realized that this cannot be dropped until my series "ARM: > dts: meson: fix UART device-tree schema validation" [0] is merged > > [...] >> -/* Legacy bindings, should be removed when no more used */ >> -OF_EARLYCON_DECLARE(meson, "amlogic,meson-uart", >> - meson_serial_early_console_setup); > This part is still needed as long as above series is not merged yet. > If we remove this then earlycon will stop working on the 32-bit SoCs > unless [0] is merged. > > All other code below - except the of_device_id entry - can still be > removed since meson8.dtsi and meson8b.dtsi are using the non-legacy > clocks already. > > Sorry for only noticing this now. > I will add it back in the next patch and delete it after your submission is merged. > > Best regards, > Martin > > > [0] https://patchwork.kernel.org/project/linux-amlogic/cover/20211227180026.4068352-1-martin.blumenstingl@googlemail.com/ >