Message-ID: <f6aa56ee-16b2-9a53-2377-07d638b1289b@gmx.com>
Date:   Fri, 31 Dec 2021 21:07:45 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Subject: Re: [PATCH] btrfs: Remove redundant initialization of slot
Content-Language: en-US
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>, clm@fb.com
Cc:     josef@toxicpanda.com, dsterba@suse.com,
        linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
        Abaci Robot <abaci@linux.alibaba.com>
References: <20211231122306.13720-1-jiapeng.chong@linux.alibaba.com>
From:   Qu Wenruo <quwenruo.btrfs@gmx.com>
In-Reply-To: <20211231122306.13720-1-jiapeng.chong@linux.alibaba.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Precedence: bulk


On 2021/12/31 20:23, Jiapeng Chong wrote:
> slot is being initialized to path->slots[0] but this is never
> read as slot is overwritten later on. Remove the redundant
> initialization.
>
> Cleans up the following clang-analyzer warning:
>
> fs/btrfs/tree-log.c:6125:7: warning: Value stored to 'slot' during its
> initialization is never read [clang-analyzer-deadcode.DeadStores].
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
>   fs/btrfs/tree-log.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/tree-log.c b/fs/btrfs/tree-log.c
> index 9165486b554e..c083562a3334 100644
> --- a/fs/btrfs/tree-log.c
> +++ b/fs/btrfs/tree-log.c
> @@ -6122,7 +6122,7 @@ static int log_new_ancestors(struct btrfs_trans_ha=
ndle *trans,
>   	while (true) {
>   		struct btrfs_fs_info *fs_info =3D root->fs_info;
>   		struct extent_buffer *leaf =3D path->nodes[0];
> -		int slot =3D path->slots[0];
> +		int slot;

If you're cleaning up slot, then why not also cleaning up leaf?

And again, no feedback no matter what on other patches from you, and
still CC to maintainers.


>   		struct btrfs_key search_key;
>   		struct inode *inode;
>   		u64 ino;