From:   "Khandelwal, Rajat" <rajat.khandelwal@intel.com>
To:     "mika.westerberg@linux.intel.com" <mika.westerberg@linux.intel.com>,
        "Krogerus, Heikki" <heikki.krogerus@intel.com>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "platform-driver-x86@vger.kernel.org" 
        <platform-driver-x86@vger.kernel.org>,
        "Westerberg, Mika" <mika.westerberg@intel.com>
Subject: RE: [PATCH] platform/x86: intel_scu_ipc: Keep polling IPC status if
 it reads IPC_STATUS_ERR
Thread-Topic: [PATCH] platform/x86: intel_scu_ipc: Keep polling IPC status if
 it reads IPC_STATUS_ERR
Thread-Index: AQHX/VdVI9fbyn2ZKUGZmpjZsx6tm6xMwTug
Date:   Fri, 31 Dec 2021 15:49:56 +0000
Message-ID: <CO1PR11MB48352F856F280F0E3716972196469@CO1PR11MB4835.namprd11.prod.outlook.com>
References: <20211230082353.2585-1-rajat.khandelwal@intel.com>
In-Reply-To: <20211230082353.2585-1-rajat.khandelwal@intel.com>
Accept-Language: en-US
Content-Language: en-US
dlp-version: 11.6.200.16
dlp-product: dlpe-windows
dlp-reaction: no-action
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?1BkGkPC4BaTxIftlwyY3LSJ5/E+6d44dj6ARF1hZ0P8mOWArcQf8lPejwBPG?=
 =?us-ascii?Q?BgHKqIPbg0Iv17vL72UVP4z8fZeL+G9QvXBAe3oo5yeU7bQf/8TNmevy4Vae?=
 =?us-ascii?Q?LLlo2ZZ78Vfe21YQFpogQB7fkQ/yxeC73KPVlDm0DA1kEI8s9DNrlBsOEIkk?=
 =?us-ascii?Q?SGnrugTvoD1Ogolnl6uVVntykwSKkoZAzN43b0cfuuaZa9LtDCtF2qxCamBs?=
 =?us-ascii?Q?vTLsTBxq9+SW8gvXKCfrC0Ejx65Xa9D68jsBoGSkZLbLwIHxg94yrvJVgENO?=
 =?us-ascii?Q?DxYg2X/BEUpr62InNnBFniNpUC/uxqCFOpYaUVtpGOXwKpWgJ44QZWq44LdC?=
 =?us-ascii?Q?ve56P6kIv/hSvn/1wQvQWbBWw3m4JYvu1KR8gWKNUsPQfTkQXGPCc7+gUvMs?=
 =?us-ascii?Q?eX4kjuvmWp6QgR0zIWMRF8NRlXZuF9ptHs2otKa6ACw2vFIUqX7/uGpswPAM?=
 =?us-ascii?Q?eS4co4W1CqmI/dAphX4TxqQmo5z4KYJlqDdF/OJ3UPiJDCy+7u+o5NGzVjy6?=
 =?us-ascii?Q?UdIoKVveYUzp66rgszzv/ECwWM9czZQxR7nv7agYDLaJY3Da7Z8SfASd89ho?=
 =?us-ascii?Q?QT91stdEtelp+R3Lo9D6N/ZIAulQiD5v3CZ+e4rHDveHw8NijdSO3yp4FVHz?=
 =?us-ascii?Q?gHvBLgmpSL5I8n3AZRg7cJIodE1UMvSJJYhy5W/JVwK4n4e52WzSazWKnNWc?=
 =?us-ascii?Q?4lnySghX4LE9WJdmfwTT77gF0jRE0KqsZCO1J1PfgakVj6322T8SBZM54tWL?=
 =?us-ascii?Q?dxpGaOD7kvWZunH7fMi/l5c9wM6uNL4j4Hx0NeOFV7JVgjCOkOKBurXytucx?=
 =?us-ascii?Q?B+NaKkqx1GIkt/KKBhAWDSRsX9vZ3scZ/Cfyn0lm4VQCcsMHMePaegZuQDOb?=
 =?us-ascii?Q?yX+gp9OkiXIxcvZTA5dhPtdCPxrgkfnL++4QtnjS6CuaqDJI9zhVMd8+ysiP?=
 =?us-ascii?Q?sL794Rn29q15U1tMYGlAQAW+zY5RLOqn0S8h1N1V09H9RQmCQOK4nRb7gARN?=
 =?us-ascii?Q?0GbK+UeN64SsBZmwcWIVCdHh9XM/I+6zvhJ0ky9c0ph+hr2OOCI2WGKHgNud?=
 =?us-ascii?Q?EtyepF7/0qxGL4NUQp61lL2qKTul9n7qys9BzfuJNMdfOy5msRIOkFl6m19T?=
 =?us-ascii?Q?HA9LvX7kEarAeraK4eiaJuDxZergHyedx2c3peDH6ciP5wBR4FTFNk4Q8s0f?=
 =?us-ascii?Q?M5ycK5SXfv/AMalhOPKkKLt85AdLhA5/K2Uu5vIjTznxT80F9FLBe2rYgwXk?=
 =?us-ascii?Q?dBkRczHbPc0eOMvfSmRUEK34fnLBztK2bhlJX5oiTDDjl0A7zS5zNIuIQ8+T?=
 =?us-ascii?Q?t1w/9PwNoPez3CriQ13goDxLYnEThCaWErZB6J2f+aPmoS1jPGZyPoD9kkt1?=
 =?us-ascii?Q?HKMLpPisrleBysWKoYTCgKZYTfv3giISH1/i2Cj0G9WWy6txVIfw+/0WfRpz?=
 =?us-ascii?Q?LOq4Wlpv65CnXgTYTD02jbDOyhEQUw3tkFttJ/Hl70i0i1JAKT9TfW1BEaga?=
 =?us-ascii?Q?l2xExd67F7h/pjmDsN2DqN4QPLNCjQT+43UVyfr8olmMU5GPfvkozNlIEqbH?=
 =?us-ascii?Q?agdo/2KeGqas5uFhvt47JrkMnVpcVThkWB29LWW4vapnhlrBXmFGupk1ekYR?=
 =?us-ascii?Q?A2Bbo+ulAvcDPUFbz0wocDt4iYJDl5XMUZpRoN6uEIgwL9YP/R0sdXeaUH37?=
 =?us-ascii?Q?kTmt7Q=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4835.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9f72dbc0-989a-40b8-6d9e-08d9cc7531bc
X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Dec 2021 15:49:56.6370
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 4qRg2cOZgH8h25n1c6SJ5V3IPyJyzARDwWo68i3PxoYX65e/OeB9nK/imprQ+98wGU9BZcJCub7SZyO4RC1vY8eYhgTtIhIEybU4U9tJCNQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1501
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Adding ++Heikki

Thanks
Rajat
-----Original Message-----
From: Khandelwal, Rajat <rajat.khandelwal@intel.com>=20
Sent: Thursday, December 30, 2021 1:54 PM
To: mika.westerberg@linux.intel.com
Cc: linux-kernel@vger.kernel.org; platform-driver-x86@vger.kernel.org; Khan=
delwal, Rajat <rajat.khandelwal@intel.com>; Westerberg, Mika <mika.westerbe=
rg@intel.com>
Subject: [PATCH] platform/x86: intel_scu_ipc: Keep polling IPC status if it=
 reads IPC_STATUS_ERR

The current implementation returns -EIO if and when IPC_STATUS_ERR is retur=
ned and returns -ETIMEDOUT even if the status is busy.
This patch polls the IPC status even if IPC_STATUS_ERR is returned until ti=
meout expires and returns -EBUSY if the status shows busy.
Observed in multiple scenarios, trying to fetch the status of IPC after it =
shows ERR sometimes eradicates the ERR status.

Signed-off-by: Rajat-Khandelwal <rajat.khandelwal@intel.com>
---
 drivers/platform/x86/intel_scu_ipc.c | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/drivers/platform/x86/intel_scu_ipc.c b/drivers/platform/x86/in=
tel_scu_ipc.c
index 7cc9089d1e14..1f90acaa7212 100644
--- a/drivers/platform/x86/intel_scu_ipc.c
+++ b/drivers/platform/x86/intel_scu_ipc.c
@@ -233,17 +233,23 @@ static inline u32 ipc_data_readl(struct intel_scu_ipc=
_dev *scu, u32 offset)  static inline int busy_loop(struct intel_scu_ipc_de=
v *scu)  {
 	unsigned long end =3D jiffies + IPC_TIMEOUT;
+	u32 status;
=20
 	do {
-		u32 status;
-
 		status =3D ipc_read_status(scu);
-		if (!(status & IPC_STATUS_BUSY))
-			return (status & IPC_STATUS_ERR) ? -EIO : 0;
+		if (!(status & IPC_STATUS_BUSY)) {
+			if (!(status & IPC_STATUS_ERR))
+				return 0;
+		}
=20
 		usleep_range(50, 100);
 	} while (time_before(jiffies, end));
=20
+	if (status & IPC_STATUS_BUSY)
+		return -EBUSY;
+	if (status & IPC_STATUS_ERR)
+		return -EIO;
+
 	return -ETIMEDOUT;
 }
=20
--
2.17.1