Date:   Fri, 31 Dec 2021 18:14:26 +0100
Message-ID: <s5hk0fkofwt.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Christian Lachner <gladiac@gmail.com>
Cc:     perex@perex.cz, tiwai@suse.com, kailang@realtek.com,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] ALSA: hda/realtek - Fix silent output on Gigabyte X570 Aorus Master after reboot from Windows
In-Reply-To: <20211231102138.3226-2-gladiac@gmail.com>
References: <20211231102138.3226-1-gladiac@gmail.com>
        <20211231102138.3226-2-gladiac@gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Fri, 31 Dec 2021 11:21:38 +0100,
Christian Lachner wrote:
> 
> +static void alc1220_fixup_gb_x570(struct hda_codec *codec,
> +				     const struct hda_fixup *fix,
> +				     int action)
> +{
> +	static const hda_nid_t conn1[] = { 0x0c };
> +
> +	if (action != HDA_FIXUP_ACT_PRE_PROBE)
> +		return;
> +
> +	alc_write_coef_idx(codec, 0x1a, 0x01c1);
> +	alc_write_coef_idx(codec, 0x1b, 0x0202);
> +	alc_write_coef_idx(codec, 0x43, 0x3005);
> +	alc_write_coef_idx(codec, 0x58, 0x8fd6);
> +	alc_write_coef_idx(codec, 0x5f, 0xa3c5);
> +	alc_write_coef_idx(codec, 0x6a, 0x0232);

Those could be better with struct coef_fw table to be processed via
alc_process_coef_fw().

Also the coef update needs to be performed not only at PRE_INIT but
also at each resume, so this should be better done for action ==
HDA_FIXUP_ACT_INIT, I suppose.


thanks,

Takashi