Date:   Fri, 31 Dec 2021 18:17:09 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     Gagan Kumar <gagan1kumar.cs@gmail.com>
Cc:     Jeremy Kerr <jk@codeconstruct.com.au>, matt@codeconstruct.com.au,
        davem@davemloft.net, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mctp: Remove only static neighbour on RTM_DELNEIGH
Message-ID: <20211231181709.7f46dbfc@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
In-Reply-To: <65c90674808fc0a93c7d329067bf3e80736a003a.camel@gmail.com>
References: <20211228130956.8553-1-gagan1kumar.cs@gmail.com>
        <20211230175112.7daeb74e@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
        <e20e47833649b5141fa327aa8113e34d4b1bbe15.camel@codeconstruct.com.au>
        <65c90674808fc0a93c7d329067bf3e80736a003a.camel@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Fri, 31 Dec 2021 17:44:15 +0530 Gagan Kumar wrote:
> > > Can you clarify the motivation and practical impact of the change 
> > > in the commit message to make it clear? AFAICT this is a no-op / prep
> > > for some later changes, right Jeremy?  
> > 
> > Yes, it'll be a no-op now; I'm not aware of any changes coming that
> > require parameterisation of the neighbour type yet.
> > 
> > Gagan - can you provide any context on this change?  
> 
> I was exploring the repository and wanted to get familiar with the
> patching process. During that, I was looking for some TODOs in /net for
> my first patch and came across mctp.
> 
> I thought `TODO: add a "source" flag so netlink can only delete static
> neighbours?` might be of some use in the future. So, thought of sending
> a patch for the same.
> 
> If I were to think like a critic, "You aren't gonna need it" principle
> can be applied here.
> 
> If you think it's ok to proceed I can update the commit message to
> include the motivation and impact as a no-op.

SGTM