Subject: Re: [PATCH 0/2] of: unittest: re-implement overlay tracking
From:   Frank Rowand <frowand.list@gmail.com>
To:     Rob Herring <robh+dt@kernel.org>, erhard_f@mailbox.org,
        yinxiujiang@kylinos.cn
Cc:     devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220101033329.1277779-1-frowand.list@gmail.com>
Message-ID: <d1af4cc8-eb7e-ec83-0e15-11d3d4791a29@gmail.com>
Date:   Fri, 31 Dec 2021 21:39:49 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <20220101033329.1277779-1-frowand.list@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Erhard,

Can you please check whether this patch series fixes the shift-out-of-bounds
problem you reported?

-Frank


On 12/31/21 9:33 PM, frowand.list@gmail.com wrote:
> From: Frank Rowand <frank.rowand@sony.com>
> 
> Some overlays are tracked when they are applied.  The tracked overlays
> are later removed after the overlay tests are completed.  The old
> implementation makes assumptions about the expected values for
> overlay changeset id created by the overlay apply which result
> in fragile code.  The new code removes the assumptions.
> 
> A symptom that exposes a problem with the tracking code is a
> warning "UBSAN: shift-out-of-bounds in drivers/of/unittest.c:1933:36",
> Kernel Version: 5.15-rc7, PPC-64, Talos II.  This results from variable
> "id" value of -1 in the final line of of_unittest_untrack_overlay().
> 
> The first patch in the series cleans up the inconsistent use of overlay
> changeset id and the obsolete overlay id.  The id is a core concept in
> the overlay tracking that is re-implemented in the second patch in
> the series.
> 
> Frank Rowand (2):
>   of: unittest: change references to obsolete overlay id
>   of: unittest: re-implement overlay tracking
> 
>  drivers/of/unittest.c | 154 +++++++++++++++++++-----------------------
>  1 file changed, 71 insertions(+), 83 deletions(-)
>