Subject: Re: [PATCH v17 1/7] usb: misc: Add onboard_usb_hub driver
To:     Matthias Kaehlcke <mka@chromium.org>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Alan Stern <stern@rowland.harvard.edu>,
        Rob Herring <robh+dt@kernel.org>,
        Frank Rowand <frowand.list@gmail.com>,
        Mathias Nyman <mathias.nyman@intel.com>,
        Felipe Balbi <balbi@kernel.org>, linux-kernel@vger.kernel.org,
        Krzysztof Kozlowski <krzk@kernel.org>,
        Stephen Boyd <swboyd@chromium.org>,
        Peter Chen <peter.chen@kernel.org>, linux-usb@vger.kernel.org,
        devicetree@vger.kernel.org,
        Douglas Anderson <dianders@chromium.org>,
        Roger Quadros <rogerq@kernel.org>,
        Michal Simek <michal.simek@xilinx.com>,
        Ravi Chandra Sadineni <ravisadineni@chromium.org>,
        Bastien Nocera <hadess@hadess.net>
References: <20211116200739.924401-1-mka@chromium.org>
 <20211116120642.v17.1.I7c9a1f1d6ced41dd8310e8a03da666a32364e790@changeid>
 <07781322-3632-7d63-0da8-a651a438a3ff@gmail.com>
 <Yc4T1qSkcRF2iBVg@google.com>
From:   Dmitry Osipenko <digetx@gmail.com>
Message-ID: <1c37be43-4102-6afe-fb05-4cac21ac4d98@gmail.com>
Date:   Sat, 1 Jan 2022 15:23:22 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <Yc4T1qSkcRF2iBVg@google.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

30.12.2021 23:17, Matthias Kaehlcke пишет:
> On Mon, Dec 20, 2021 at 11:05:28PM +0300, Dmitry Osipenko wrote:
>> 16.11.2021 23:07, Matthias Kaehlcke пишет:
>>> +static const struct usb_device_id onboard_hub_id_table[] = {
>>> +	{ USB_DEVICE(VENDOR_ID_REALTEK, 0x0411) }, /* RTS0411 USB 3.0 */
>>> +	{ USB_DEVICE(VENDOR_ID_REALTEK, 0x5411) }, /* RTS5411 USB 2.0 */
>>> +	{},
>>> +};
>>
>> RTS5411 two times in the comments?
> 
> One time, the other is RTS0511
> 
>> Internet suggests that RTS5411 is USB 3.0
> 
> Correct, however the chip internally has two hubs, one for USB2 and one for
> USB3:
> 
>   Bus 002 Device 002: ID 0bda:0411 Realtek Semiconductor Corp. 4-Port USB 3.1 Hub
>   Bus 001 Device 002: ID 0bda:5411 Realtek Semiconductor Corp. 4-Port USB 2.1 Hub

Alright, thanks.

>> Are these hubs expected to be powered-on only when upstream port is
>> enabled? Shouldn't runtime PM be used for that somehow?
> 
> In the general case I would expect that a onboard hub is connected to a port
> that is enabled. For now I think it's fine to power the hub always when the
> system is running (which is also the current situation with using always-on
> regulators). If someone has an actual use case where the upstream port can
> be disabled they can add support for that later.
> 

I see that you're handling the wakeup-capable devices during the
driver's suspend, perhaps it should work okay then.

BTW, shouldn't the "companion-hub" need to be turned into a generic USB
property? The onboard-usb-hub looks like a generic thing, but
"companion-hub" is specific to the RTS5411 binding.