Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752513AbXA2R2l (ORCPT ); Mon, 29 Jan 2007 12:28:41 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752515AbXA2R2l (ORCPT ); Mon, 29 Jan 2007 12:28:41 -0500 Received: from calculon.skynet.ie ([193.1.99.88]:44103 "EHLO calculon.skynet.ie" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752513AbXA2R2k (ORCPT ); Mon, 29 Jan 2007 12:28:40 -0500 Date: Mon, 29 Jan 2007 17:28:39 +0000 (GMT) From: Mel Gorman X-X-Sender: mel@skynet.skynet.ie To: Christoph Lameter Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/8] Create the ZONE_MOVABLE zone In-Reply-To: Message-ID: References: <20070125234458.28809.5412.sendpatchset@skynet.skynet.ie> <20070125234538.28809.24662.sendpatchset@skynet.skynet.ie> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 920 Lines: 30 On Fri, 26 Jan 2007, Christoph Lameter wrote: > On Thu, 25 Jan 2007, Mel Gorman wrote: > >> @@ -166,6 +168,8 @@ enum zone_type { >> #define ZONES_SHIFT 1 >> #elif __ZONE_COUNT <= 4 >> #define ZONES_SHIFT 2 >> +#elif __ZONE_COUNT <= 8 >> +#define ZONES_SHIFT 3 >> #else > > You do not need a shift of 3. Even with ZONE_MOVABLE the maximum > number of zones is still 4. > Yep, this is correct. If it's ever wrong, there is an additional check for __ZONE_COUNT that will print out the appropriate warning. Thanks -- Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/