Date:   Sat, 1 Jan 2022 08:44:26 -0800
From:   "Paul E. McKenney" <paulmck@kernel.org>
To:     Zqiang <qiang1.zhang@intel.com>
Cc:     frederic@kernel.org, linux-kernel@vger.kernel.org,
        bigeasy@linutronix.de
Subject: Re: [PATCH] rcu: per-cpu rcuc kthread are created only when
 rcutree.use_softirq=0
Message-ID: <20220101164426.GA2408833@paulmck-ThinkPad-P17-Gen-1>
Reply-To: paulmck@kernel.org
References: <20211228160510.2893362-1-qiang1.zhang@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211228160510.2893362-1-qiang1.zhang@intel.com>
Precedence: bulk

On Wed, Dec 29, 2021 at 12:05:10AM +0800, Zqiang wrote:
> In non-RT kernel, if the RCU_BOOST is enabled, the per-cpu rcuc
> kthread will be created, however under the rcutree.use_softirq=1,
> the RCU core processing only in softirq context, the rcuc kthread
> doesn't do anything, so remove RCU_BOOST interference.
> 
> Signed-off-by: Zqiang <qiang1.zhang@intel.com>

Looks sane to me, but adding Sebastian on CC for his thoughts.

							Thanx, Paul

> ---
>  kernel/rcu/tree.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
> index 9b58bae0527a..ed64b4fcb8a0 100644
> --- a/kernel/rcu/tree.c
> +++ b/kernel/rcu/tree.c
> @@ -2902,7 +2902,7 @@ static int __init rcu_spawn_core_kthreads(void)
>  
>  	for_each_possible_cpu(cpu)
>  		per_cpu(rcu_data.rcu_cpu_has_work, cpu) = 0;
> -	if (!IS_ENABLED(CONFIG_RCU_BOOST) && use_softirq)
> +	if (use_softirq)
>  		return 0;
>  	WARN_ONCE(smpboot_register_percpu_thread(&rcu_cpu_thread_spec),
>  		  "%s: Could not start rcuc kthread, OOM is now expected behavior\n", __func__);
> -- 
> 2.25.1
>