Message-ID: <aef1ecb9-0757-0bbf-74a5-70d88fd52e08@kernel.org>
Date:   Sat, 1 Jan 2022 19:25:34 +0200
MIME-Version: 1.0
Subject: Re: [PATCH v2 1/3] interconnect: imx: Switch from
 imx_icc_node_adj_desc to fsl,icc-id node assignment
Content-Language: en-US
To:     Abel Vesa <abel.vesa@nxp.com>, Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>
Cc:     Pengutronix Kernel Team <kernel@pengutronix.de>,
        NXP Linux Team <linux-imx@nxp.com>, linux-pm@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
References: <20220101163956.3344467-1-abel.vesa@nxp.com>
From:   Georgi Djakov <djakov@kernel.org>
In-Reply-To: <20220101163956.3344467-1-abel.vesa@nxp.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Abel,

Thanks for working on this!

On 1.01.22 18:39, Abel Vesa wrote:
> In order to be able to have more than one NoCs in the interconnect net
> we need to decouple the NoC from the dram. So instead of using the
> imx_icc_node_adj_desc, we use the fsl,icc-id property that is in
> each NoC (or pl301) to the icc node (based on the id) to it.

I believe that this DT property should be documented somewhere.
Maybe in Documentation/devicetree/bindings/interconnect/fsl,imx8m-noc.yaml?

BR,
Georgi

> Along with all the NoC and pl301 nodes in the dts we will have a
> interconnect dedicated node. This node will be the actual device of the
> icc provider.
> 
> Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
> ---
> 
> No changes since v1.
> 
>   drivers/interconnect/imx/imx.c | 70 +++++++++++++++-------------------
>   1 file changed, 31 insertions(+), 39 deletions(-)