Message-ID: <3741398c-b3e2-4872-d08f-9de02fe3cab9@quicinc.com>
Date:   Sun, 2 Jan 2022 11:57:12 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Subject: Re: [PATCH] dt-bindings: qcom,pdc: convert to YAML
To:     Luca Weiss <luca.weiss@fairphone.com>,
        <linux-arm-msm@vger.kernel.org>
CC:     <~postmarketos/upstreaming@lists.sr.ht>,
        <phone-devel@vger.kernel.org>, Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Marc Zyngier <maz@kernel.org>,
        "Rob Herring" <robh+dt@kernel.org>, <linux-kernel@vger.kernel.org>,
        <devicetree@vger.kernel.org>
References: <20211213152208.290923-1-luca.weiss@fairphone.com>
 <39d259cf-5663-5073-f16b-71a21f0e62e3@quicinc.com>
 <CGROQPIOKGRH.2UVREF2IWAOIC@otso>
From:   Maulik Shah <quic_mkshah@quicinc.com>
In-Reply-To: <CGROQPIOKGRH.2UVREF2IWAOIC@otso>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Luca,

On 12/29/2021 3:11 PM, Luca Weiss wrote:
> Hi Maulik,
>
> On Mon Dec 20, 2021 at 1:24 PM CET, Maulik Shah wrote:
>> Hi Luca,
>>
>> On 12/13/2021 8:52 PM, Luca Weiss wrote:
>>> Convert the PDC interrupt controller bindings to YAML.
>>>
>>> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
>>> ---
>>> This patch depends on the following patch, which fixed sm8250 & sm8350
>>> compatibles and adds sm6350.
>>> https://lore.kernel.org/linux-arm-msm/20211213082614.22651-4-luca.weiss@fairphone.com/
>>>
>>> Also, if somebody has a better suggestion for the register names,
>>> the second one is pulled from downstream commit message which calls it
>>> both "SPI config registers" and "interface registers":
>>> https://source.codeaurora.org/quic/la/kernel/msm-4.19/commit/?id=cdefb63745e051a5bcf69663ac9d084d7da1eeec
>> Thanks for the patch. Please use "apss-shared-spi-cfg" name for the
>> second reg.
>>
>> It was intended in [1] to remove it since there are no user in upstream
>> for second reg. but it should be fine to convert existing to yaml first
>> and then look to fix that.
>>
> Do you have a full-text version of that? I'd use it instead of this in
> the binding.
>
>    - description: PDC interface register region
you can use below description,

description: Edge or Level config register for SPI interrupts

Thanks,
Maulik