Date: Mon, 29 Jan 2007 09:49:50 -0800 (PST)
From: Christoph Lameter <clameter@sgi.com>
To: Andrew Morton <akpm@osdl.org>
cc: Frederik Deweerdt <deweerdt@free.fr>, linux-kernel@vger.kernel.org,
       trond.myklebust@fys.uio.no, Christoph Lameter <clameter@engr.sgi.com>
Subject: Re: [-mm patch] BUG at net/sunrpc/svc.c:128 (was Re: 2.6.20-rc6-mm2)
In-Reply-To: <20070129093247.54ba43c9.akpm@osdl.org>
Message-ID: <Pine.LNX.4.64.0701290948090.28644@schroedinger.engr.sgi.com>
References: <20070129001207.71ea3470.akpm@osdl.org> <20070129112141.GC2990@slug>
 <20070129093247.54ba43c9.akpm@osdl.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 997
Lines: 32

On Mon, 29 Jan 2007, Andrew Morton wrote:

> >  static int
> >  svc_pool_map_init_percpu(struct svc_pool_map *m)
> >  {
> > -	unsigned int maxpools = nr_node_ids;
> > +	unsigned int maxpools = num_online_cpus();
> >  	unsigned int pidx = 0;
> >  	unsigned int cpu;
> >  	int err;
> 
> Thanks.

Patch has the wrong solution as detailed in another message.

The line should be reverted to what it was before:

  unsigned int maxpools = highest_possible_processor_id()+1;


> Christoph, can you pleeeeeze be more careful?  A few seconds inattention
> and a dopey copy-n-paste bug leads to large amounts of wasted time for
> other people.

Looks like I need to add another nr_cpu_ids? I did not realize that the 
same weird thing was done for cpus, sigh.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/