Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751171AbXA2SCt (ORCPT ); Mon, 29 Jan 2007 13:02:49 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751996AbXA2SCt (ORCPT ); Mon, 29 Jan 2007 13:02:49 -0500 Received: from pentafluge.infradead.org ([213.146.154.40]:33362 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751171AbXA2SCs (ORCPT ); Mon, 29 Jan 2007 13:02:48 -0500 Date: Mon, 29 Jan 2007 18:02:34 +0000 From: Christoph Hellwig To: Stephen Smalley Cc: Christoph Hellwig , Peter Zijlstra , Andrew Morton , linux-kernel@vger.kernel.org, Ingo Molnar , James Morris , Eric Paris Subject: Re: [PATCH 0/7] breaking the global file_list_lock Message-ID: <20070129180233.GA17754@infradead.org> Mail-Followup-To: Christoph Hellwig , Stephen Smalley , Peter Zijlstra , Andrew Morton , linux-kernel@vger.kernel.org, Ingo Molnar , James Morris , Eric Paris References: <20070128115118.837777000@programming.kicks-ass.net> <20070128144325.GB16552@infradead.org> <20070128151122.GA21159@infradead.org> <1170077573.8720.30.camel@moss-spartans.epoch.ncsc.mil> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1170077573.8720.30.camel@moss-spartans.epoch.ncsc.mil> User-Agent: Mutt/1.4.2.2i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 900 Lines: 19 On Mon, Jan 29, 2007 at 08:32:53AM -0500, Stephen Smalley wrote: > > - fs/selinuxfs.c:sel_remove_bools() > > > > Utter madness. I have no idea how this ever got merged. > > Maybe the selinux folks can explain what crack they were > > on when writing this. The problem would go away with > > a generic rewoke infrastructure. > > It was modeled after proc_kill_inodes(), as noted in the comments. So > if you have a suitable replacement for proc_kill_inodes(), you can apply > the same approach to sel_remove_bools(). Looking at it again sel_remove_bools actually only operates on files backed by selinuxfs, so yes we could use the same approach. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/