Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752064AbXA2SDp (ORCPT ); Mon, 29 Jan 2007 13:03:45 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752527AbXA2SDp (ORCPT ); Mon, 29 Jan 2007 13:03:45 -0500 Received: from calculon.skynet.ie ([193.1.99.88]:44966 "EHLO calculon.skynet.ie" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752064AbXA2SDo (ORCPT ); Mon, 29 Jan 2007 13:03:44 -0500 X-Greylist: delayed 1946 seconds by postgrey-1.27 at vger.kernel.org; Mon, 29 Jan 2007 13:03:43 EST Date: Mon, 29 Jan 2007 17:31:16 +0000 To: Christoph Lameter Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/8] Create the ZONE_MOVABLE zone Message-ID: <20070129173116.GA19568@skynet.ie> References: <20070125234458.28809.5412.sendpatchset@skynet.skynet.ie> <20070125234538.28809.24662.sendpatchset@skynet.skynet.ie> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.9i From: mel@skynet.ie (Mel Gorman) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2249 Lines: 46 On (26/01/07 09:16), Christoph Lameter didst pronounce: > I do not see any updates of vmstat.c and vmstat.h. This > means that VM statistics are not kept / considered for ZONE_MOVABLE. Based on searching around for ZONE_DMA32, the following patch appears to be all that is required; diff -rup -X /usr/src/patchset-0.6/bin//dontdiff linux-2.6.20-rc4-mm1-009_backout_zonecount/include/linux/vmstat.h linux-2.6.20-rc4-mm1-010_update_zonecounters/include/linux/vmstat.h --- linux-2.6.20-rc4-mm1-009_backout_zonecount/include/linux/vmstat.h 2007-01-17 17:08:36.000000000 +0000 +++ linux-2.6.20-rc4-mm1-010_update_zonecounters/include/linux/vmstat.h 2007-01-29 16:52:42.000000000 +0000 @@ -24,7 +24,7 @@ #define HIGHMEM_ZONE(xx) #endif -#define FOR_ALL_ZONES(xx) DMA_ZONE(xx) DMA32_ZONE(xx) xx##_NORMAL HIGHMEM_ZONE(xx) +#define FOR_ALL_ZONES(xx) DMA_ZONE(xx) DMA32_ZONE(xx) xx##_NORMAL HIGHMEM_ZONE(xx) , xx##_MOVABLE enum vm_event_item { PGPGIN, PGPGOUT, PSWPIN, PSWPOUT, FOR_ALL_ZONES(PGALLOC), @@ -171,7 +171,8 @@ static inline unsigned long node_page_st #ifdef CONFIG_HIGHMEM zone_page_state(&zones[ZONE_HIGHMEM], item) + #endif - zone_page_state(&zones[ZONE_NORMAL], item); + zone_page_state(&zones[ZONE_NORMAL], item) + + zone_page_state(&zones[ZONE_MOVABLE], item); } extern void zone_statistics(struct zonelist *, struct zone *); diff -rup -X /usr/src/patchset-0.6/bin//dontdiff linux-2.6.20-rc4-mm1-009_backout_zonecount/mm/vmstat.c linux-2.6.20-rc4-mm1-010_update_zonecounters/mm/vmstat.c --- linux-2.6.20-rc4-mm1-009_backout_zonecount/mm/vmstat.c 2007-01-17 17:08:39.000000000 +0000 +++ linux-2.6.20-rc4-mm1-010_update_zonecounters/mm/vmstat.c 2007-01-29 16:52:42.000000000 +0000 @@ -456,7 +456,7 @@ const struct seq_operations fragmentatio #endif #define TEXTS_FOR_ZONES(xx) TEXT_FOR_DMA(xx) TEXT_FOR_DMA32(xx) xx "_normal", \ - TEXT_FOR_HIGHMEM(xx) + TEXT_FOR_HIGHMEM(xx) xx "_movable", static const char * const vmstat_text[] = { /* Zoned VM counters */ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/