Date:   Sun, 2 Jan 2022 11:34:23 -0300
From:   Arnaldo Carvalho de Melo <acme@kernel.org>
To:     John Garry <john.garry@huawei.com>
Cc:     peterz@infradead.org, mingo@redhat.com, mark.rutland@arm.com,
        alexander.shishkin@linux.intel.com, jolsa@redhat.com,
        namhyung@kernel.org, irogers@google.com, kan.liang@linux.intel.com,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
        zhengjun.xing@linux.intel.com
Subject: Re: [PATCH v2] perf pmu: Fix alias events list
Message-ID: <YdG378o4kx4zbRSo@kernel.org>
References: <1640103090-140490-1-git-send-email-john.garry@huawei.com>
 <05dcd009-084c-b8ee-c4a5-35c0862ee26d@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <05dcd009-084c-b8ee-c4a5-35c0862ee26d@huawei.com>
Precedence: bulk

Em Tue, Dec 28, 2021 at 09:00:18PM +0000, John Garry escreveu:
> On 21/12/2021 16:11, John Garry wrote:
> > Commit 0e0ae8742207 ("perf list: Display hybrid PMU events with cpu type")
> > changes the event list for uncore PMUs or arm64 heterogeneous CPU systems,
> > such that duplicate aliases are incorrectly listed per PMU (which they
> > should not be), like:
> > 
> > ./perf list
> > ...
> > unc_cbo_cache_lookup.any_es
> > [Unit: uncore_cbox L3 Lookup any request that access cache and found
> > line in E or S-state]
> > unc_cbo_cache_lookup.any_es
> > [Unit: uncore_cbox L3 Lookup any request that access cache and found
> > line in E or S-state]
> > unc_cbo_cache_lookup.any_i
> > [Unit: uncore_cbox L3 Lookup any request that access cache and found
> > line in I-state]
> > unc_cbo_cache_lookup.any_i
> > [Unit: uncore_cbox L3 Lookup any request that access cache and found
> > line in I-state]
> > ...
> > 
> > Notice how the events are listed twice.
> 
> 
> Hi Arnaldo,
> 
> Can you kindly consider picking up this change for v5.16?

Applied, will send a pull req to Linus soon.

- Arnaldo