MIME-Version: 1.0
References: <20211226025215.22866-1-rdunlap@infradead.org>
In-Reply-To: <20211226025215.22866-1-rdunlap@infradead.org>
From:   Ian Rogers <irogers@google.com>
Date:   Sun, 2 Jan 2022 17:01:53 -0800
Message-ID: <CAP-5=fXHUg9jEOmGxCk3UP2mdb8oSCyg-UenL1k7MhLFAaaj5Q@mail.gmail.com>
Subject: Re: [PATCH] perf: fix typos of "its" and "reponse"
To:     Randy Dunlap <rdunlap@infradead.org>,
        Andi Kleen <ak@linux.intel.com>,
        "zhengjun.xing@intel.com" <zhengjun.xing@intel.com>
Cc:     linux-kernel@vger.kernel.org,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@redhat.com>,
        Namhyung Kim <namhyung@kernel.org>,
        linux-perf-users@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sat, Dec 25, 2021 at 6:52 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> Use the possessive "its" instead of the contraction of "it is" ("it's")
> where needed in user-viewable messages.
>
> Correct typos of "reponse" to "response" (reported by checkpatch).
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
> Cc: Jiri Olsa <jolsa@redhat.com>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Cc: linux-perf-users@vger.kernel.org

Making this information better is valuable! The data is autogenerated
by these scripts:
https://github.com/intel/event-converter-for-linux-perf
From data here:
https://download.01.org/perfmon/
In a way the files that are in the tree are temporary build files.
Perhaps we can have the original source and scripts within the Linux
tools tree to simplify fixes like these.

Thanks,
Ian


> ---
>  tools/perf/pmu-events/arch/x86/broadwell/uncore.json          |    6 +++=
---
>  tools/perf/pmu-events/arch/x86/cascadelakex/uncore-other.json |    4 ++-=
-
>  tools/perf/pmu-events/arch/x86/haswell/uncore.json            |    6 +++=
---
>  tools/perf/pmu-events/arch/x86/skylakex/uncore-other.json     |    4 ++-=
-
>  4 files changed, 10 insertions(+), 10 deletions(-)
>
> --- linux-next-20211224.orig/tools/perf/pmu-events/arch/x86/broadwell/unc=
ore.json
> +++ linux-next-20211224/tools/perf/pmu-events/arch/x86/broadwell/uncore.j=
son
> @@ -184,8 +184,8 @@
>      "EventCode": "0x80",
>      "UMask": "0x01",
>      "EventName": "UNC_ARB_TRK_OCCUPANCY.ALL",
> -    "BriefDescription": "Each cycle count number of all Core outgoing va=
lid entries. Such entry is defined as valid from it's allocation till first=
 of IDI0 or DRS0 messages is sent out. Accounts for Coherent and non-cohere=
nt traffic.",
> -    "PublicDescription": "Each cycle count number of all Core outgoing v=
alid entries. Such entry is defined as valid from it's allocation till firs=
t of IDI0 or DRS0 messages is sent out. Accounts for Coherent and non-coher=
ent traffic.",
> +    "BriefDescription": "Each cycle count number of all Core outgoing va=
lid entries. Such entry is defined as valid from its allocation till first =
of IDI0 or DRS0 messages is sent out. Accounts for Coherent and non-coheren=
t traffic.",
> +    "PublicDescription": "Each cycle count number of all Core outgoing v=
alid entries. Such entry is defined as valid from its allocation till first=
 of IDI0 or DRS0 messages is sent out. Accounts for Coherent and non-cohere=
nt traffic.",
>      "Counter": "0,",
>      "CounterMask": "0",
>      "Invert": "0",
> @@ -275,4 +275,4 @@
>      "Invert": "0",
>      "EdgeDetect": "0"
>    }
> -]
> \ No newline at end of file
> +]
> --- linux-next-20211224.orig/tools/perf/pmu-events/arch/x86/cascadelakex/=
uncore-other.json
> +++ linux-next-20211224/tools/perf/pmu-events/arch/x86/cascadelakex/uncor=
e-other.json
> @@ -514,7 +514,7 @@
>          "EventCode": "0x5C",
>          "EventName": "UNC_CHA_SNOOP_RESP.RSP_FWD_WB",
>          "PerPkg": "1",
> -        "PublicDescription": "Counts when a transaction with the opcode =
type Rsp*Fwd*WB Snoop Response was received which indicates the data was wr=
itten back to it's home socket, and the cacheline was forwarded to the requ=
estor socket.  This snoop response is only used in >=3D 4 socket systems.  =
It is used when a snoop HITM's in a remote caching agent and it directly fo=
rwards data to a requestor, and simultaneously returns data to it's home so=
cket to be written back to memory.",
> +        "PublicDescription": "Counts when a transaction with the opcode =
type Rsp*Fwd*WB Snoop Response was received which indicates the data was wr=
itten back to its home socket, and the cacheline was forwarded to the reque=
stor socket.  This snoop response is only used in >=3D 4 socket systems.  I=
t is used when a snoop HITM's in a remote caching agent and it directly for=
wards data to a requestor, and simultaneously returns data to its home sock=
et to be written back to memory.",
>          "UMask": "0x20",
>          "Unit": "CHA"
>      },
> @@ -524,7 +524,7 @@
>          "EventCode": "0x5C",
>          "EventName": "UNC_CHA_SNOOP_RESP.RSP_WBWB",
>          "PerPkg": "1",
> -        "PublicDescription": "Counts when a transaction with the opcode =
type Rsp*WB Snoop Response was received which indicates which indicates the=
 data was written back to it's home.  This is returned when a non-RFO reque=
st hits a cacheline in the Modified state. The Cache can either downgrade t=
he cacheline to a S (Shared) or I (Invalid) state depending on how the syst=
em has been configured.  This reponse will also be sent when a cache reques=
ts E (Exclusive) ownership of a cache line without receiving data, because =
the cache must acquire ownership.",
> +        "PublicDescription": "Counts when a transaction with the opcode =
type Rsp*WB Snoop Response was received which indicates which indicates the=
 data was written back to its home.  This is returned when a non-RFO reques=
t hits a cacheline in the Modified state. The Cache can either downgrade th=
e cacheline to a S (Shared) or I (Invalid) state depending on how the syste=
m has been configured.  This response will also be sent when a cache reques=
ts E (Exclusive) ownership of a cache line without receiving data, because =
the cache must acquire ownership.",
>          "UMask": "0x10",
>          "Unit": "CHA"
>      },
> --- linux-next-20211224.orig/tools/perf/pmu-events/arch/x86/haswell/uncor=
e.json
> +++ linux-next-20211224/tools/perf/pmu-events/arch/x86/haswell/uncore.jso=
n
> @@ -304,8 +304,8 @@
>      "EventCode": "0x80",
>      "UMask": "0x01",
>      "EventName": "UNC_ARB_TRK_OCCUPANCY.ALL",
> -    "BriefDescription": "Each cycle count number of all Core outgoing va=
lid entries. Such entry is defined as valid from it's allocation till first=
 of IDI0 or DRS0 messages is sent out. Accounts for Coherent and non-cohere=
nt traffic.",
> -    "PublicDescription": "Each cycle count number of all Core outgoing v=
alid entries. Such entry is defined as valid from it's allocation till firs=
t of IDI0 or DRS0 messages is sent out. Accounts for Coherent and non-coher=
ent traffic.",
> +    "BriefDescription": "Each cycle count number of all Core outgoing va=
lid entries. Such entry is defined as valid from its allocation till first =
of IDI0 or DRS0 messages is sent out. Accounts for Coherent and non-coheren=
t traffic.",
> +    "PublicDescription": "Each cycle count number of all Core outgoing v=
alid entries. Such entry is defined as valid from its allocation till first=
 of IDI0 or DRS0 messages is sent out. Accounts for Coherent and non-cohere=
nt traffic.",
>      "Counter": "0",
>      "CounterMask": "0",
>      "Invert": "0",
> @@ -371,4 +371,4 @@
>      "Invert": "0",
>      "EdgeDetect": "0"
>    }
> -]
> \ No newline at end of file
> +]
> --- linux-next-20211224.orig/tools/perf/pmu-events/arch/x86/skylakex/unco=
re-other.json
> +++ linux-next-20211224/tools/perf/pmu-events/arch/x86/skylakex/uncore-ot=
her.json
> @@ -514,7 +514,7 @@
>          "EventCode": "0x5C",
>          "EventName": "UNC_CHA_SNOOP_RESP.RSP_FWD_WB",
>          "PerPkg": "1",
> -        "PublicDescription": "Counts when a transaction with the opcode =
type Rsp*Fwd*WB Snoop Response was received which indicates the data was wr=
itten back to it's home socket, and the cacheline was forwarded to the requ=
estor socket.  This snoop response is only used in >=3D 4 socket systems.  =
It is used when a snoop HITM's in a remote caching agent and it directly fo=
rwards data to a requestor, and simultaneously returns data to it's home so=
cket to be written back to memory.",
> +        "PublicDescription": "Counts when a transaction with the opcode =
type Rsp*Fwd*WB Snoop Response was received which indicates the data was wr=
itten back to its home socket, and the cacheline was forwarded to the reque=
stor socket.  This snoop response is only used in >=3D 4 socket systems.  I=
t is used when a snoop HITM's in a remote caching agent and it directly for=
wards data to a requestor, and simultaneously returns data to its home sock=
et to be written back to memory.",
>          "UMask": "0x20",
>          "Unit": "CHA"
>      },
> @@ -524,7 +524,7 @@
>          "EventCode": "0x5C",
>          "EventName": "UNC_CHA_SNOOP_RESP.RSP_WBWB",
>          "PerPkg": "1",
> -        "PublicDescription": "Counts when a transaction with the opcode =
type Rsp*WB Snoop Response was received which indicates which indicates the=
 data was written back to it's home.  This is returned when a non-RFO reque=
st hits a cacheline in the Modified state. The Cache can either downgrade t=
he cacheline to a S (Shared) or I (Invalid) state depending on how the syst=
em has been configured.  This reponse will also be sent when a cache reques=
ts E (Exclusive) ownership of a cache line without receiving data, because =
the cache must acquire ownership.",
> +        "PublicDescription": "Counts when a transaction with the opcode =
type Rsp*WB Snoop Response was received which indicates which indicates the=
 data was written back to its home.  This is returned when a non-RFO reques=
t hits a cacheline in the Modified state. The Cache can either downgrade th=
e cacheline to a S (Shared) or I (Invalid) state depending on how the syste=
m has been configured.  This response will also be sent when a cache reques=
ts E (Exclusive) ownership of a cache line without receiving data, because =
the cache must acquire ownership.",
>          "UMask": "0x10",
>          "Unit": "CHA"
>      },