From:   Saurav Kashyap <skashyap@marvell.com>
To:     Jiasheng Jiang <jiasheng@iscas.ac.cn>,
        Javed Hasan <jhasan@marvell.com>,
        GR-QLogic-Storage-Upstream <GR-QLogic-Storage-Upstream@marvell.com>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "linux@armlinux.org.uk" <linux@armlinux.org.uk>
CC:     "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: RE: [EXT] [PATCH] scsi: qedf: potential dereference of null pointer
Thread-Topic: [EXT] [PATCH] scsi: qedf: potential dereference of null pointer
Thread-Index: AQHX8mXGRWO7SF21CECbm2a/GitlN6xQ15PQ
Date:   Mon, 3 Jan 2022 04:58:41 +0000
Message-ID: <DM6PR18MB30344528373170A95E67B50CD2499@DM6PR18MB3034.namprd18.prod.outlook.com>
References: <20211216101449.375953-1-jiasheng@iscas.ac.cn>
In-Reply-To: <20211216101449.375953-1-jiasheng@iscas.ac.cn>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?V4M6Zo9l8ax/lRKm1hHI9XYZT0fBaWmG74ZV/jB6orrCzJ//F5cYat9BVSEY?=
 =?us-ascii?Q?BOZFPOPygDzZdymQOVT/MY8RD+xsuVVBmn6vIlrVnCB0/zgpHkv3XvEd8d0U?=
 =?us-ascii?Q?jdr6ktN+/5sYpFwtGczuMwjYajSLuvNHzR30F3K512kaMYkuYBIM+v7NuUyk?=
 =?us-ascii?Q?olr1svGYyJOBZj6hw2/Lf5xNzlO3kqn6FEYnc+1fpMh2QsTsKxp2ZwVbARv9?=
 =?us-ascii?Q?5GVYfLJlQlTLd1SrMNnXn4tB+BGbboHPYwm02EBtUV9IdQN2alRJOFwjmyg2?=
 =?us-ascii?Q?wTSBylsSzBejBRpDBH9HzXnz0eVKIQ6FaUeNEaYZi2ZtlVhKBEfgVUz4SkvT?=
 =?us-ascii?Q?Ogou90xyL0Ce73lCX3ENr1HNqxj8XdVjt9SRZt8bSLHA9ycfFytFwl/si2zg?=
 =?us-ascii?Q?rvn4fUqLp/OmHMhcBcNYxD+BLdcH7D4PI9demfVNzWAJmV4zVMKokgaek4GF?=
 =?us-ascii?Q?Q9kL11OsQvykLcfC45lbT/7BzFblWbsDeFh0NLGzAxzGvrOd2527zPfTVyx8?=
 =?us-ascii?Q?59MqEF6ieZtWcrTezDQVyxe1GMhqEoMcBUWPqhcQSV8ffMDhcP/u6P1DLXNC?=
 =?us-ascii?Q?tmgWTrSY6dCUV8viAQEjqrxxYgEcTSmyB803PaT18HFxGa4a1fzJlVVpezbb?=
 =?us-ascii?Q?fN6I0VUgkT8NGRYDrCj7SGWhUiMHs9HKd+V3OoSzzyPGX2QsV/E48aM6ZhFB?=
 =?us-ascii?Q?OLTXVACtGZwJh8N/wp2O8qXkDdB0h7PTR6OmpZkVuPwdZKPRkGq9XEWK61iD?=
 =?us-ascii?Q?I+FUgvrBrnRx2o7+G/eJC+k39rcbM3JzxXJTZB+c0WYzd9r6YvBa9s8ijT6C?=
 =?us-ascii?Q?heTiFzRTjVJSaD/sxHyG6PgVt0hBOzRhHBOAXzavr4RGLHgH53fea094+1Ge?=
 =?us-ascii?Q?OAi79eYE/51EE+qZXWQZxXFRkSw7doHzcUQRrSclsmEgnGsC/pSnigCzAbPT?=
 =?us-ascii?Q?hS1RcUNTQi3he0SeNErR9v+rn0OQKQNm/tlemFXt1KODswoEAA+eAEpekOzB?=
 =?us-ascii?Q?716s2a14mKeQpI7VG3IuEInSO/nvUpW5m8Tpq36xoPSm2JEkf6lw37vbR1ff?=
 =?us-ascii?Q?YXTFy937bXZ0CiyJyw9DAZu8zTk4lfma1yPsWJlMmfQLLo5WP80MsTmp3kV2?=
 =?us-ascii?Q?VQYiDmBWG/R7bin8xV1UxXPz6tTNhv+D57mtAQkExWoe10gVhC0GdDDgH3iG?=
 =?us-ascii?Q?ZFjHwmfQiogtBSeNx/MG53dYjehvYvpD4jPggdGO7L8aY3J2Of/Wle6LWomw?=
 =?us-ascii?Q?+czB2bugNHU42ZIk8kCgruswMNS9qzcxEyEm6gnxoP1VPD8Jct+N4t7TMwFa?=
 =?us-ascii?Q?F6l/M5H69yZwmu7ZsC8OEim1k82D1efoQhzKmXYdGyaa2dZW5g/C4TqoFriP?=
 =?us-ascii?Q?3nwiCcXKYk06rohEwcpzSuvUvm2C6nMbf5M79CyjkzXs1u8p7OiTCGblgc2P?=
 =?us-ascii?Q?Y1iYEHB+TPicFlSKMO7u+Tbf/qMf7gjgSxR8bxT5RFz4Mny5vpFRBmvh9aQ/?=
 =?us-ascii?Q?FfWmZ3QpflFg6j2vuQ3Vs+mh8H/l5bTYbtQunRegqRxwfCPKhmPvEwnaaIur?=
 =?us-ascii?Q?oqdQg09cXOF2KP6xP8Ae/bnZTG1QAx+aImi7De9dJbO42vljRpP1llzzXwZw?=
 =?us-ascii?Q?VAZhBq+HhUXyFIeuz4bFMBY=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR18MB3034.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7d4b14d3-a1f2-49e5-d742-08d9ce75b69d
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Jan 2022 04:58:41.8991
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: wg/SD1iUqGLF7SNou4Z4eYjw4zBnd1b+GgITc9gT6k2puJec+ESJEsigjjhE0Z5r5n/12Sycw6Ghx68hu9wZ+Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR18MB3036
X-Proofpoint-GUID: kqnictLs6-e-M-X4IbVOYhc60RwhowMR
X-Proofpoint-ORIG-GUID: hRF2YRBtNKQlWR-vqdMjWC-rVmnk9eNW
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-01-03_01,2022-01-01_01,2021-12-02_01
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Jiasheng Jiang,

> -----Original Message-----
> From: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> Sent: Thursday, December 16, 2021 3:45 PM
> To: Saurav Kashyap <skashyap@marvell.com>; Javed Hasan
> <jhasan@marvell.com>; GR-QLogic-Storage-Upstream <GR-QLogic-Storage-
> Upstream@marvell.com>; jejb@linux.ibm.com; martin.petersen@oracle.com;
> linux@armlinux.org.uk
> Cc: linux-scsi@vger.kernel.org; linux-kernel@vger.kernel.org;
> netdev@vger.kernel.org; Jiasheng Jiang <jiasheng@iscas.ac.cn>
> Subject: [EXT] [PATCH] scsi: qedf: potential dereference of null pointer
>=20
> External Email
>=20
> ----------------------------------------------------------------------
> The return value of dma_alloc_coherent() needs to be checked.
> To avoid use of null pointer in case of the failure of alloc.
>=20
> Fixes: 61d8658b4a43 ("scsi: qedf: Add QLogic FastLinQ offload FCoE driver
> framework.")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> ---
>  drivers/scsi/qedf/qedf_main.c | 2 ++
>  1 file changed, 2 insertions(+)
>=20
> diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.=
c
> index b92570a7c309..309e205a8e70 100644
> --- a/drivers/scsi/qedf/qedf_main.c
> +++ b/drivers/scsi/qedf/qedf_main.c
> @@ -1415,6 +1415,8 @@ static void qedf_upload_connection(struct qedf_ctx
> *qedf,
>  	 */
>  	term_params =3D dma_alloc_coherent(&qedf->pdev->dev,
> QEDF_TERM_BUFF_SIZE,
>  		&term_params_dma, GFP_KERNEL);
> +	if (!term_params)
> +		return;

<SK> Adding message about failure before returning will help in debugging.

Thanks,
~Saurav
>=20
>  	QEDF_INFO(&(qedf->dbg_ctx), QEDF_LOG_CONN, "Uploading
> connection "
>  		   "port_id=3D%06x.\n", fcport->rdata->ids.port_id);
> --
> 2.25.1