Date:   Mon, 3 Jan 2022 14:17:11 +0100
From:   Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To:     "Paul E. McKenney" <paulmck@kernel.org>
Cc:     Zqiang <qiang1.zhang@intel.com>, frederic@kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rcu: per-cpu rcuc kthread are created only when
 rcutree.use_softirq=0
Message-ID: <YdL3Vx6pq6YCL1kx@linutronix.de>
References: <20211228160510.2893362-1-qiang1.zhang@intel.com>
 <20220101164426.GA2408833@paulmck-ThinkPad-P17-Gen-1>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20220101164426.GA2408833@paulmck-ThinkPad-P17-Gen-1>
Precedence: bulk

On 2022-01-01 08:44:26 [-0800], Paul E. McKenney wrote:
> On Wed, Dec 29, 2021 at 12:05:10AM +0800, Zqiang wrote:
> > In non-RT kernel, if the RCU_BOOST is enabled, the per-cpu rcuc
> > kthread will be created, however under the rcutree.use_softirq=1,
> > the RCU core processing only in softirq context, the rcuc kthread
> > doesn't do anything, so remove RCU_BOOST interference.
> > 
> > Signed-off-by: Zqiang <qiang1.zhang@intel.com>
> 
> Looks sane to me, but adding Sebastian on CC for his thoughts.

Yes, it makes sense. invoke_rcu_core_kthread() is only invoked for
!use_softirq so it makes to create the threads based on this condition.

Acked-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>

> 							Thanx, Paul

Sebastian