Date:   Mon, 3 Jan 2022 14:28:40 +0100
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Abdun Nihaal <abdun.nihaal@gmail.com>
Cc:     Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
        straube.linux@gmail.com, martin@kaiser.cx,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: r8188eu: remove unneeded ret variables
Message-ID: <YdL6CE3+CaU6xVvD@kroah.com>
References: <20211231172527.184788-1-abdun.nihaal@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211231172527.184788-1-abdun.nihaal@gmail.com>
Precedence: bulk

On Fri, Dec 31, 2021 at 10:55:27PM +0530, Abdun Nihaal wrote:
> Remove unneeded return variables in ioctl_linux.c that are initialized
> to 0 and are not assigned after. Instead, return 0 directly.

Almost all of these should not be returning a value at all, if they can
not fail and no one checks the values, right?

Please fix this up to be functions that return void, as that's the
correct thing to do here.

thanks,

greg k-h