Message-ID: <b583dc48-a6b6-f6c7-4a5a-678d985ce358@googlemail.com>
Date:   Mon, 3 Jan 2022 13:35:23 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Subject: Re: 5.16.0-rc7+ Bluetooth error
Content-Language: en-GB
To:     "K, Kiran" <kiran.k@intel.com>,
        Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
References: <02077a37-46d6-c94f-fa08-9da7ee99e42c@googlemail.com>
 <50ea1b0e-28d7-6d04-9c03-4becc4db143b@googlemail.com>
 <CABBYNZLc9Pj=LYhL5MUUVkhenHb_xfT59aDDkdk14k7+ojeUzw@mail.gmail.com>
 <DM8PR11MB55735DD3A1EA9132E1A71733F5499@DM8PR11MB5573.namprd11.prod.outlook.com>
From:   Chris Clayton <chris2553@googlemail.com>
In-Reply-To: <DM8PR11MB55735DD3A1EA9132E1A71733F5499@DM8PR11MB5573.namprd11.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 03/01/2022 09:55, K, Kiran wrote:
> Hi Luiz, Chris,
> 
>> -----Original Message-----
>> From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
>> Sent: Saturday, January 1, 2022 1:23 AM
>> To: Chris Clayton <chris2553@googlemail.com>
>> Cc: LKML <linux-kernel@vger.kernel.org>; linux-bluetooth@vger.kernel.org;
>> K, Kiran <kiran.k@intel.com>
>> Subject: Re: 5.16.0-rc7+ Bluetooth error
>>
>> Hi Chris,
>>
>> On Fri, Dec 31, 2021 at 2:35 AM Chris Clayton <chris2553@googlemail.com>
>> wrote:
>>>
>>> On 30/12/2021 09:21, Chris Clayton wrote:
>>>> Hi,
>>>>
>>>> I pulled the latest changes into my clone of Linus' tree and built
>>>> and installed the kernel. (git describe gives
>>>> v5.16-rc7-9-ge7c124bd0463). I'm seeing errors reported by the
>>>> bluetooth subsystem that i don't see in 5.15.12 or 5.10.89
>>>>
>>>> The problem seems to occur twice during system startup and on each
>> occasion I see a batch of identical error messages:
>>>>
>>>> [    3.980822] Bluetooth: hci0: Failed to read codec capabilities (-56)
>>>> [    3.982812] Bluetooth: hci0: Failed to read codec capabilities (-56)
>>>> [    3.984812] Bluetooth: hci0: Failed to read codec capabilities (-56)
>>>> [    3.986608] Bluetooth: hci0: Failed to read codec capabilities (-56)
>>>> [    3.987621] Bluetooth: hci0: Failed to read codec capabilities (-56)
>>>> [    3.988606] Bluetooth: hci0: Failed to read codec capabilities (-56)
>>>> [    3.989650] Bluetooth: hci0: Failed to read codec capabilities (-56)
>>>>
>>>
>>> Sorry, I should have said that despite the above errors, my bluetooth
>> devices still work fine.
>>
>> Would be great to have the HCI trace (btmon).
>>
>> @Kiran K Is this to be expected?
> 
> May be the BT controller here is not supporting HCI_READ_CODEC_CAPABILITIES command.
> 
> This has been fixed - https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git/commit/?id=107fe0482b549a0e43a971e5fd104719c6e495ef
> 

I've applied the patch to 5.16.0-rc8 and the error messages are no longer produced. My bluetooth devices are stiil working.

Tested-By: Chris Clayton <chris2553@googlemail.com>

> A check has been added to read codec capabilities only if supported.
> 
> Thanks,
> Kiran
>