Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.7\))
Subject: Re: [RFC PATCH 6/9] arm64: dts: meson: add initial device-trees for
 A95XF3-AIR
From:   Christian Hewitt <christianshewitt@gmail.com>
In-Reply-To: <6ff128a6-91cb-5b83-737e-e703cab81743@baylibre.com>
Date:   Mon, 3 Jan 2022 19:26:49 +0400
Cc:     Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Kevin Hilman <khilman@baylibre.com>,
        devicetree <devicetree@vger.kernel.org>,
        linux-arm-kernel@lists.infradead.org,
        linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
        Benoit Masson <yahoo@perenite.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <F8463510-1955-4826-BE05-20F3B4079ED4@gmail.com>
References: <20211130060523.19161-1-christianshewitt@gmail.com>
 <20211130060523.19161-7-christianshewitt@gmail.com>
 <6ff128a6-91cb-5b83-737e-e703cab81743@baylibre.com>
To:     Neil Armstrong <narmstrong@baylibre.com>
Precedence: bulk


> On 3 Jan 2022, at 7:21 pm, Neil Armstrong <narmstrong@baylibre.com> =
wrote:
>=20
> Hi,
>=20
> On 30/11/2021 07:05, Christian Hewitt wrote:
>> The CYX A95XF3-AIR is based on Amlogic S905X3 reference board
>> designs and ships in multiple configurations:
>>=20
>> =E2=80=93 4GB DDR3 + 64GB eMMC + WiFi a/b/g/n/ac + BT + Gb Ethernet
>> =E2=80=93 4GB DDR3 + 32GB eMMC + WiFi a/b/g/n/ac + BT + Gb Ethernet
>> =E2=80=93 2GB DDR3 + 16GB eMMC + WiFi b/g/n (no BT) + 10/100 Ethernet
>> ...
>> - HDMI 2.1 video
>> - S/PDIF optical output
>> - AV output
>> - 1x USB 2.0 OTG port
>> - 1x USB 3.0 port
>> - IR receiver
>> - 1x micro SD card slot (internal)
>> - 1x Reset/Update button (in AV jack)
>> - 7-segment VFD
>> - Multicolour case LED 'arc'
>>=20
>> The device-tree with -100 suffix supports models with 10/100 Ethernet
>> and with -1000 suffix supports models with Gigabit Ethernet.
>=20
> I thought about this, and I think we should have:
> - meson-sm1-a95xf3-air.dts for 10/100 version
> - meson-sm1-a95xf3-air-gbit.dts for gigabit 10/100/1000 version
>=20
> With this, I'm ok to apply the serie.
>=20
> Neil

That=E2=80=99s fine with me, thanks for the review. I=E2=80=99ll rework =
the patches and
send a v2 series to the list.

Christian