Message-ID: <7560b350e7b23786ce712118a9a504356ff1cca4.camel@kernel.org>
Subject: Re: [PATCH] ceph: replace DEFINE_SIMPLE_ATTRIBUTE with
 DEFINE_DEBUGFS_ATTRIBUTE
From:   Jeff Layton <jlayton@kernel.org>
To:     Ilya Dryomov <idryomov@gmail.com>
Cc:     cgel.zte@gmail.com, Ceph Development <ceph-devel@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Changcheng Deng <deng.changcheng@zte.com.cn>,
        Zeal Robot <zealci@zte.com.cn>
Date:   Mon, 03 Jan 2022 10:30:15 -0500
In-Reply-To: <CAOi1vP-uVjgcbHj6n_BesjS6-9H+02P-cy=1MKZsy9wk=OW7-Q@mail.gmail.com>
References: <20211221143614.480385-1-deng.changcheng@zte.com.cn>
         <bc8803b511ed25ddc7091ba1f09f10ca415ca51e.camel@kernel.org>
         <CAOi1vP-uVjgcbHj6n_BesjS6-9H+02P-cy=1MKZsy9wk=OW7-Q@mail.gmail.com>
Content-Type: text/plain; charset="ISO-8859-15"
User-Agent: Evolution 3.42.2 (3.42.2-1.fc35) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon, 2022-01-03 at 16:03 +0100, Ilya Dryomov wrote:
> On Mon, Jan 3, 2022 at 3:41 PM Jeff Layton <jlayton@kernel.org> wrote:
> > 
> > On Tue, 2021-12-21 at 14:36 +0000, cgel.zte@gmail.com wrote:
> > > From: Changcheng Deng <deng.changcheng@zte.com.cn>
> > > 
> > > Fix the following coccicheck warning:
> > > ./fs/ceph/debugfs.c: 390: 0-23: WARNING: congestion_kb_fops should be
> > > defined with DEFINE_DEBUGFS_ATTRIBUTE
> > > 
> > > Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE for
> > > debugfs files.
> > > 
> > > Reported-by: Zeal Robot <zealci@zte.com.cn>
> > > Signed-off-by: Changcheng Deng <deng.changcheng@zte.com.cn>
> > > ---
> > >  fs/ceph/debugfs.c | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/fs/ceph/debugfs.c b/fs/ceph/debugfs.c
> > > index 3cf7c9c1085b..64c4158c17c8 100644
> > > --- a/fs/ceph/debugfs.c
> > > +++ b/fs/ceph/debugfs.c
> > > @@ -387,8 +387,8 @@ static int congestion_kb_get(void *data, u64 *val)
> > >       return 0;
> > >  }
> > > 
> > > -DEFINE_SIMPLE_ATTRIBUTE(congestion_kb_fops, congestion_kb_get,
> > > -                     congestion_kb_set, "%llu\n");
> > > +DEFINE_DEBUGFS_ATTRIBUTE(congestion_kb_fops, congestion_kb_get,
> > > +                      congestion_kb_set, "%llu\n");
> > > 
> > > 
> > >  void ceph_fs_debugfs_cleanup(struct ceph_fs_client *fsc)
> > 
> > Thanks, merged into our testing branch. This should make v5.17.
> 
> Hi Jeff,
> 
> This came up last year, has anything changed?
> 
> https://www.spinics.net/lists/ceph-devel/msg50492.html
> 

Good point, that discussion had totally slipped my mind. Dropping this
patch again for now until the rationale is clearer.

Jiapeng, could you clarify why you didn't do the other part of that
conversion?

Thanks, 
-- 
Jeff Layton <jlayton@kernel.org>