From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Horatiu Vultur <horatiu.vultur@microchip.com>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "f.fainelli@gmail.com" <f.fainelli@gmail.com>,
        "vivien.didelot@gmail.com" <vivien.didelot@gmail.com>,
        "andrew@lunn.ch" <andrew@lunn.ch>
Subject: Re: [PATCH net-next 1/3] net: lan966x: Add function
 lan966x_mac_cpu_copy()
Thread-Topic: [PATCH net-next 1/3] net: lan966x: Add function
 lan966x_mac_cpu_copy()
Thread-Index: AQHYAKMIDc/8QMjaPk+JwRMQCQIKvKxRWuoAgAAT6QCAAAIsAA==
Date:   Mon, 3 Jan 2022 15:46:57 +0000
Message-ID: <20220103154656.4irkytj6dpxne2py@skbuf>
References: <20220103131039.3473876-1-horatiu.vultur@microchip.com>
 <20220103131039.3473876-2-horatiu.vultur@microchip.com>
 <20220103142754.vtotw3clkwdrvcrd@skbuf>
 <20220103153910.pntxvz7qjaodd6s3@soft-dev3-1.localhost>
In-Reply-To: <20220103153910.pntxvz7qjaodd6s3@soft-dev3-1.localhost>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?mFJu5pgp+r3rJYZ4KvQACttKSizh9Is92Ci+HOYOHsSEpZuhirEpCw8P+uHG?=
 =?us-ascii?Q?lOZ6WGcvmFhwa19Na6Cl1C28iKkTRa+Pwpii70RRucQ3cBwMArAk+Ac3Bimx?=
 =?us-ascii?Q?ADiHOiQkqQnZ+RqWiJ3RqgXvn/fGEtSrmVWD4sxB5ljbp7Mg5qD9prix1O99?=
 =?us-ascii?Q?zUzhwQhI98bz0oFAuxY7V0/fcEEFt56jjsZ7tlsO4jQp8LaNEse8NFz/tFgm?=
 =?us-ascii?Q?a94pztzcrhxkDmElUshsWz3XPJUBdNemVdb8xlUG3DJ/zgraLjTzpbo+QwC0?=
 =?us-ascii?Q?/54GRXvw8KVMcepn9Qjqi3IEefz2z87h93Xob7I5PN62alefjT/JUu//56/B?=
 =?us-ascii?Q?1neveRXmrt2Rrdi6iUcBVR7YgIHacttObWR5V8or2NncDzRPmjo2Xlebuk+1?=
 =?us-ascii?Q?fh01HxYgywue9vs7U0eMw0kGmlJxTNJVbnZmy3xSJzQK/Zyf8Kx5dfLEXyjm?=
 =?us-ascii?Q?QBBVDfK3xpFu9o3DWH+N0L1oKyhEAFaszjpZVHbXQQOhKo3NLcqNfYoLspU2?=
 =?us-ascii?Q?+u+4cHhGx8DmPqw+DrHj/LshWE/SOG8LnxriaXX90SZDo+PiHKXeWOgYxcEq?=
 =?us-ascii?Q?9P6T8JcB8JTYTo9ch6Y/jJ0BTvLOn3Wuq1CtbVDzwWLT4WXS2YNPYkdWeFyg?=
 =?us-ascii?Q?O53d6VJ5Tn9GT+6IXJSDZgEGTelrCIGjCtwyiPBv7WHVV8AWmRK6NzNbrFz7?=
 =?us-ascii?Q?MaqDh/GfC+la2kWItfHPcbAPcdndANrBoJP5SCkio/vXqu1qZVh/0c8gvs43?=
 =?us-ascii?Q?18cJhOsYEvMOUk+CzzSzAM/MuurR6NHBNXeVgIO356M37y3BhWfd9YfKIIG6?=
 =?us-ascii?Q?sYLofmR3P5RGuOsTLIT246kH0+0ANygVKggbwXgCBZscV7sbTfuVX5BlxvC0?=
 =?us-ascii?Q?600irBfYAn9lKLtzF2LZqhJaUmsUBAYBObgAjY5taWy4aI16coPYUYeU2xzl?=
 =?us-ascii?Q?BWbrdIrpTePp6Mfp6ciWc86EubNA9Tuf/nZ0UZotDEQkW90/VMplAikWqZkz?=
 =?us-ascii?Q?r6WJQdva5kpPWasqMdfzNYzc1Bfty/aC0onr2B5Kr29IXXe/20EwYk7xoXbo?=
 =?us-ascii?Q?RcIXs8E5j38WkHIYFpKHe5QonR9q+A92nQdkUQLKRgeqbnxalHSzda0iPZEZ?=
 =?us-ascii?Q?GCrPLDdCd+RgOwz5AO0VWoCGgZD5Y8ny3DDpG+ZJ62qOYLFDLgn/4JwLl/WG?=
 =?us-ascii?Q?FUMgRLrbRvgfcBZYeXKCK3x1IJ6p/rgkjyT6A6FFSktwpH3+EZF05jhhm25E?=
 =?us-ascii?Q?jBodxMazIE2h7NFyyt6jIf3ma2s3XZue06VU/CtKK8pdQc8ZDZQJGk/XEzxH?=
 =?us-ascii?Q?NSUCqLcUGSjhua3Ihngj6qmOKkK13y2PyvNEPXKBhBjpXbU+tdWZEjnGZ70x?=
 =?us-ascii?Q?42bdkE0WuFoSP6JS7ZmsuRizfBQ8aRKAt8I/6jlbhDjO9r5ZYqcYW3dmy+DH?=
 =?us-ascii?Q?rFZ60OXH1LcKET84BXOocqy++cOgesK6tlnOdAFLO34NPGT72DZU376N2SDC?=
 =?us-ascii?Q?WnS750MrUwU0CexqBSFwScWYRDammpzqNNd8H9JU9hafsL86rIqNv7T4Ih8d?=
 =?us-ascii?Q?sFb9+iINbmrqxiW/YxLpIb3gXxq3KQmSOFEAaKHSpCGnNLK/SlVic8KiCBG/?=
 =?us-ascii?Q?Wuj659yKSm0AVgIGWKRVlT0=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1887D2BFE49279439480D1588D562A23@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3ad0dfcd-7b0a-456b-ad59-08d9ced04610
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Jan 2022 15:46:57.3028
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ecJCS4cjuKLJjSR/ogmpNTxr7bttM8j0xmZfAAgVlkUuxSsdsRScJCMMGJvhkAU1pBt5Sr6Jw46jhLZybunJUQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3615
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jan 03, 2022 at 04:39:10PM +0100, Horatiu Vultur wrote:
> > > +int lan966x_mac_learn(struct lan966x *lan966x, int port,
> > > +                   const unsigned char mac[ETH_ALEN],
> > > +                   unsigned int vid,
> > > +                   enum macaccess_entry_type type)
> > > +{
> > > +     return lan966x_mac_learn_impl(lan966x, port, false, mac, vid, t=
ype);
> >=20
> > If you call lan966x_mac_cpu_copy() on an address and then
> > lan966x_mac_learn() on the same address but on an external port, how
> > does that work (why doesn't the "false" here overwrite the cpu_copy in
> > the previous command, breaking the copy-to-CPU feature)?
>=20
> Then you will overwrite the cpu_copy so the frames will not reach the
> CPU anymore.
> But you should not do that. The function lan966x_mac_cpu_copy() should be
> used for IPv4/IPv6 and lan966x_mac_learn() for the other types.
>=20
> Maybe the function lan966x_mac_cpu_copy() is too generic. It should be
> something like lan966x_mac_ipv4(), lan966x_mac_ipv6() and these functions
> will call __lan966x_mac_learn with the correct parameters. Also I can
> add a WARN_ON(...) inside lan966x_mac_learn not to be used with the
> IPv4/IPv6 types.

The intended usage pattern isn't clear at all in the current series.=