Date:   Mon, 3 Jan 2022 10:56:26 -0800
From:   Beau Belgrave <beaub@linux.microsoft.com>
To:     Masami Hiramatsu <mhiramat@kernel.org>
Cc:     rostedt@goodmis.org, linux-trace-devel@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 02/12] user_events: Add print_fmt generation support
 for basic types
Message-ID: <20220103185626.GA15548@kbox>
References: <20211216173511.10390-1-beaub@linux.microsoft.com>
 <20211216173511.10390-3-beaub@linux.microsoft.com>
 <20211222093030.ea1f358f05a965c435592539@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211222093030.ea1f358f05a965c435592539@kernel.org>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

On Wed, Dec 22, 2021 at 09:30:30AM +0900, Masami Hiramatsu wrote:
> On Thu, 16 Dec 2021 09:35:01 -0800
> Beau Belgrave <beaub@linux.microsoft.com> wrote:
> 
> > Addes print_fmt format generation for basic types that are supported for
> > user processes. Only supports sizes that are the same on 32 and 64 bit.
> 
> Is the last sentence for user_events itself, or only limiting the
> print_fmt but user_events supports it?
> 

It's only for print_fmt to prevent incorrect decoding at that level, as
we discussed previously.

> The code looks good to me.
> 
> Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
> 
> Thank you,
> 

Thanks,
-Beau