From:   Abel Vesa <abel.vesa@nxp.com>
To:     Georgi Djakov <djakov@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>
Cc:     Pengutronix Kernel Team <kernel@pengutronix.de>,
        NXP Linux Team <linux-imx@nxp.com>, linux-pm@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [PATCH v3 2/3] interconnect: imx: Switch from imx_icc_node_adj_desc to fsl,icc-id node assignment
Date:   Mon,  3 Jan 2022 21:28:59 +0200
Message-Id: <20220103192900.946521-2-abel.vesa@nxp.com>
In-Reply-To: <20220103192900.946521-1-abel.vesa@nxp.com>
References: <20220103192900.946521-1-abel.vesa@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+EhnK/HA3/KjnPrajkjrfjre+iikhYAUyeYIR2OnFNBuCH9zTzFgeZyfCz38?=
 =?us-ascii?Q?pf90Fk9/2G5w0zG6VJobLrphRDfc9wa0bCs00UKzD8M7hIa4H2qgiD8JH58C?=
 =?us-ascii?Q?GtcnUqg872aEBJ9sC/wtnMMcpOErWY53VWQek0TwgCbg3uFznXdVTo2sPmTT?=
 =?us-ascii?Q?y7PD3aWTFt9ieG1dUXHKXDdxZuSlUBJ5Nlkm0B0fgYVKyM/d5veUV1g1GQfl?=
 =?us-ascii?Q?AUp7aYUCc0Pprnv5BeOWazJ2pkW96RnTr+NS49Olf6uUXgPThrRwF/shNU5Z?=
 =?us-ascii?Q?B6iFroJ2we+8o9YIUGK4f7gMRWwX4/zNVZd28/ls89K9dHYok2qwCfpZWsFu?=
 =?us-ascii?Q?db1VkkBqovvaCc1tAQbEkUjvUus3Ou+nvazbQjAtlSfPMvXVwoBzWj4rCj1g?=
 =?us-ascii?Q?qfOZjI+VSnmhdWZyFzzm2YGxi/0GGH8hCkA7727lqxaPlfQk8S4JfwTTxphD?=
 =?us-ascii?Q?nAoaOkH6za4GlCW+cjrh2rTWPH50zvdl/WX4mpShC+ZpMER56vX1G9LLKwVj?=
 =?us-ascii?Q?qfpMHDtWSEvv167xy3NB9GmLndOF19ThrB2MA7wul8FOsMC1+tbIMycSmHQ/?=
 =?us-ascii?Q?3dTPrpx09r22aRCfSttURcvXnb6DmRH5JEwhG1V4TCfReqKmd8xAKYqpf823?=
 =?us-ascii?Q?zICY60OYo3mbmtOso9RB83mpFvKwq+naMrVdZXHU9mfWK9ecdUK7Wb/UIn44?=
 =?us-ascii?Q?XbH+9Ee8z0rhhpqe9ECvqAG0xC+5tPLICHvZ4YSATiM2Bz1/7l/ws8Iv3XwW?=
 =?us-ascii?Q?5bQ7quneCmNV4XLgOXRwqejrN/sdtZtbcivlCfmCcYsERnIzTK0bscEkrOTE?=
 =?us-ascii?Q?N5jV6r4QOvziBt5QdkmVIiGckZQrQCwnMSdoD4ZYtHVmXxQVnukNuWZJXv50?=
 =?us-ascii?Q?ltQkMrir/dfrEI6rTa8BTZHtfnbdE09q3gggx9NzO3OJj63GcXy/7sLm/iVL?=
 =?us-ascii?Q?i2lY+F4UKZZn/UNQTt3br+Qc5hp6pz+Ds7DX7xKZH0mX22v0UMcedIcTPGwW?=
 =?us-ascii?Q?pedc0Vf4xlrnfkuVA3fhJ9Mmg7kvdwL2jmt2veDXzzvetMgFXOO7uMs77up4?=
 =?us-ascii?Q?jv8I/CpG6mrwgpbLePESdCWN7kuHy9IidPAp++HHkmDIcW9641ecZu6ikMb7?=
 =?us-ascii?Q?LevmUXcQZFtvlF80J0GvnlcSPdg+yEiFv8+AX9lqiT1oIYQPgJDn235EmcVV?=
 =?us-ascii?Q?sEeJMjLarPRRoVXWhfRMbqQpCTRN0z/LBLFOPtdBdOqnWiTcrb5FkbHmi9jn?=
 =?us-ascii?Q?kucRMfksG5L38/54bSH9aqbg1srT7NW1ciR0NVi8HdJm2rxlituffK03J7A3?=
 =?us-ascii?Q?Ys5/BO2u99qGeYZnTOa0HcJLMrV1mXQjM+Ia7XPUAePwlOjaPtoz+oUh2YUs?=
 =?us-ascii?Q?P7YR64gE6gCXbGicYvf3MqzeAS5By+gPJvWycvBgwCkPP7SB6XBAcQUTr797?=
 =?us-ascii?Q?ne2QmPrsm9vccaQEzqASJnIqOOFyUYax2e4Cywi7AW0TqTDdhqX4wqSo6NbD?=
 =?us-ascii?Q?IOaAr1n7WYhZQNtvkCuHHBUh+OFiO2YJMuDDnKWGw4JXCZFQjsJRdms9hJUk?=
 =?us-ascii?Q?IvDhaqDfqJ2JZSnLrcyb0eKVzWiqSAFQ42dLgGUhJ4qWbx1MBjcF+FUlNWnC?=
 =?us-ascii?Q?CCNNdpnvLGORGcwkOUIwUHo=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6f5c7a7c-5264-4ce3-9b07-08d9ceef647c
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB4688.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jan 2022 19:29:42.9718
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9+p0jMBq6KvBpkemivs+W15gm3ita/DPMLkGIGQQ2vIYiSvfLDspabSiYbN37U/FJcOBGz7+6Kxy/j1s+Xfx8A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7104
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

In order to be able to have more than one NoCs in the interconnect net
we need to decouple the NoC from the dram. So instead of using the
imx_icc_node_adj_desc, we use the fsl,icc-id property that is in
each NoC (or pl301) to the icc node (based on the id) to it.
Along with all the NoC and pl301 nodes in the dts we will have a
interconnect dedicated node. This node will be the actual device of the
icc provider.

Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
---

Changes since v2:
 * switch to use only peak_bw rather than choosing max between peak_bw
   and avg_bw. This renders the imx_icc_aggregate from v2 unnecessary.

 drivers/interconnect/imx/imx.c | 70 +++++++++++++++-------------------
 1 file changed, 31 insertions(+), 39 deletions(-)

diff --git a/drivers/interconnect/imx/imx.c b/drivers/interconnect/imx/imx.c
index c770951a909c..d5b36c478911 100644
--- a/drivers/interconnect/imx/imx.c
+++ b/drivers/interconnect/imx/imx.c
@@ -34,8 +34,8 @@ static int imx_icc_node_set(struct icc_node *node)
 	if (!node_data->qos_dev)
 		return 0;
 
-	freq = (node->avg_bw + node->peak_bw) * node_data->desc->adj->bw_mul;
-	do_div(freq, node_data->desc->adj->bw_div);
+	freq = node->peak_bw;
+
 	dev_dbg(dev, "node %s device %s avg_bw %ukBps peak_bw %ukBps min_freq %llukHz\n",
 		node->name, dev_name(node_data->qos_dev),
 		node->avg_bw, node->peak_bw, freq);
@@ -79,41 +79,35 @@ static int imx_icc_node_init_qos(struct icc_provider *provider,
 				 struct icc_node *node)
 {
 	struct imx_icc_node *node_data = node->data;
-	const struct imx_icc_node_adj_desc *adj = node_data->desc->adj;
 	struct device *dev = provider->dev;
-	struct device_node *dn = NULL;
 	struct platform_device *pdev;
+	struct device_node *np = NULL, *dn = NULL;
+	int idx;
 
-	if (adj->main_noc) {
-		node_data->qos_dev = dev;
-		dev_dbg(dev, "icc node %s[%d] is main noc itself\n",
-			node->name, node->id);
-	} else {
-		dn = of_parse_phandle(dev->of_node, adj->phandle_name, 0);
-		if (!dn) {
-			dev_warn(dev, "Failed to parse %s\n",
-				 adj->phandle_name);
-			return -ENODEV;
-		}
-		/* Allow scaling to be disabled on a per-node basis */
-		if (!of_device_is_available(dn)) {
-			dev_warn(dev, "Missing property %s, skip scaling %s\n",
-				 adj->phandle_name, node->name);
-			of_node_put(dn);
-			return 0;
-		}
+	for_each_node_with_property(np, "fsl,icc-id") {
+		of_property_read_u32(np, "fsl,icc-id", &idx);
+		if (idx == node_data->desc->id)
+			dn = np;
+	}
 
-		pdev = of_find_device_by_node(dn);
-		of_node_put(dn);
-		if (!pdev) {
-			dev_warn(dev, "node %s[%d] missing device for %pOF\n",
-				 node->name, node->id, dn);
-			return -EPROBE_DEFER;
-		}
-		node_data->qos_dev = &pdev->dev;
-		dev_dbg(dev, "node %s[%d] has device node %pOF\n",
-			node->name, node->id, dn);
+	if (!dn)
+		return 0;
+
+	if (!of_device_is_available(dn)) {
+		dev_warn(dev, "%pOF is disabled\n", dn);
+		return 0;
+	}
+
+	pdev = of_find_device_by_node(dn);
+	of_node_put(dn);
+	if (!pdev) {
+		dev_warn(dev, "node %s[%d] missing device for %pOF\n",
+			 node->name, node->id, dn);
+		return -EPROBE_DEFER;
 	}
+	node_data->qos_dev = &pdev->dev;
+	dev_dbg(dev, "node %s[%d] has device node %pOF\n", node->name,
+							node->id, dn);
 
 	return dev_pm_qos_add_request(node_data->qos_dev,
 				      &node_data->qos_req,
@@ -151,12 +145,10 @@ static struct icc_node *imx_icc_node_add(struct icc_provider *provider,
 	node_data->desc = node_desc;
 	icc_node_add(node, provider);
 
-	if (node_desc->adj) {
-		ret = imx_icc_node_init_qos(provider, node);
-		if (ret < 0) {
-			imx_icc_node_destroy(node);
-			return ERR_PTR(ret);
-		}
+	ret = imx_icc_node_init_qos(provider, node);
+	if (ret < 0) {
+		imx_icc_node_destroy(node);
+		return ERR_PTR(ret);
 	}
 
 	return node;
@@ -244,7 +236,7 @@ int imx_icc_register(struct platform_device *pdev,
 	provider->aggregate = icc_std_aggregate;
 	provider->xlate = of_icc_xlate_onecell;
 	provider->data = data;
-	provider->dev = dev->parent;
+	provider->dev = dev;
 	platform_set_drvdata(pdev, provider);
 
 	ret = icc_provider_add(provider);
-- 
2.31.1