MIME-Version: 1.0
References: <m3tuekbos5.fsf@nogrod.ivcecceob.t-online.de>
In-Reply-To: <m3tuekbos5.fsf@nogrod.ivcecceob.t-online.de>
From:   Linus Torvalds <torvalds@linux-foundation.org>
Date:   Mon, 3 Jan 2022 11:53:18 -0800
Message-ID: <CAHk-=whzdxBuoeTP1uJrxRQYtwOxPDYuP92c8e=_K5T1xHy7Ug@mail.gmail.com>
Subject: Re: [Regression] md/raid1: write-intent logging/bitmap issue since
 fd3b6975e9c1 - v5.16-rc1
To:     Norbert Warmuth <nwarmuth@t-online.de>,
        Jens Axboe <axboe@kernel.dk>
Cc:     Guoqing Jiang <guoqing.jiang@linux.dev>,
        Song Liu <songliubraving@fb.com>, linux-raid@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: multipart/mixed; boundary="0000000000003d9ee005d4b2e0b0"
Precedence: bulk

--0000000000003d9ee005d4b2e0b0
Content-Type: text/plain; charset="UTF-8"

[ Jens wasn't cc'd for some reason but was the signer-off-on the patch
you bisected to. Added him to the cc. I'll bounce the original
separately, as I also don't see this on lore.kernel.org - it might not
have gotten there yet ]

On Mon, Jan 3, 2022 at 11:30 AM Norbert Warmuth <nwarmuth@t-online.de> wrote:
>
> Please verify and either revert or fixup fd3b6975e9c1 if my analysis is
> correct.

Can you check if moving the WriteMostly bit to the "do behind I/O?"
section fixes things for you?

IOW, something like the attached patch..

Warning: This is very much a "Money see, monkey do" patch. I'm not
really familiar with the raid1 code ]

But yeah, if you see corruption and there isn't an absolutely trivial
fix for this, we should revert.

           Linus

--0000000000003d9ee005d4b2e0b0
Content-Type: text/x-patch; charset="US-ASCII"; name="patch.diff"
Content-Disposition: attachment; filename="patch.diff"
Content-Transfer-Encoding: base64
Content-ID: <f_kxz3mh010>
X-Attachment-Id: f_kxz3mh010

IGRyaXZlcnMvbWQvcmFpZDEuYyB8IDMgKystCiAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25z
KCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvZHJpdmVycy9tZC9yYWlkMS5jIGIvZHJp
dmVycy9tZC9yYWlkMS5jCmluZGV4IDdkYzgwMjZjZjZlZS4uODU1MDU0MjRmN2E0IDEwMDY0NAot
LS0gYS9kcml2ZXJzL21kL3JhaWQxLmMKKysrIGIvZHJpdmVycy9tZC9yYWlkMS5jCkBAIC0xNDk2
LDEyICsxNDk2LDEzIEBAIHN0YXRpYyB2b2lkIHJhaWQxX3dyaXRlX3JlcXVlc3Qoc3RydWN0IG1k
ZGV2ICptZGRldiwgc3RydWN0IGJpbyAqYmlvLAogCQlpZiAoIXIxX2Jpby0+Ymlvc1tpXSkKIAkJ
CWNvbnRpbnVlOwogCi0JCWlmIChmaXJzdF9jbG9uZSAmJiB0ZXN0X2JpdChXcml0ZU1vc3RseSwg
JnJkZXYtPmZsYWdzKSkgeworCQlpZiAoZmlyc3RfY2xvbmUpIHsKIAkJCS8qIGRvIGJlaGluZCBJ
L08gPwogCQkJICogTm90IGlmIHRoZXJlIGFyZSB0b28gbWFueSwgb3IgY2Fubm90CiAJCQkgKiBh
bGxvY2F0ZSBtZW1vcnksIG9yIGEgcmVhZGVyIG9uIFdyaXRlTW9zdGx5CiAJCQkgKiBpcyB3YWl0
aW5nIGZvciBiZWhpbmQgd3JpdGVzIHRvIGZsdXNoICovCiAJCQlpZiAoYml0bWFwICYmCisJCQkg
ICAgdGVzdF9iaXQoV3JpdGVNb3N0bHksICZyZGV2LT5mbGFncykgJiYKIAkJCSAgICAoYXRvbWlj
X3JlYWQoJmJpdG1hcC0+YmVoaW5kX3dyaXRlcykKIAkJCSAgICAgPCBtZGRldi0+Yml0bWFwX2lu
Zm8ubWF4X3dyaXRlX2JlaGluZCkgJiYKIAkJCSAgICAhd2FpdHF1ZXVlX2FjdGl2ZSgmYml0bWFw
LT5iZWhpbmRfd2FpdCkpIHsK
--0000000000003d9ee005d4b2e0b0--