Date:   Mon, 3 Jan 2022 13:54:06 -0600
From:   Venu Busireddy <venu.busireddy@oracle.com>
To:     Brijesh Singh <brijesh.singh@amd.com>
Cc:     x86@kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
        linux-efi@vger.kernel.org, platform-driver-x86@vger.kernel.org,
        linux-coco@lists.linux.dev, linux-mm@kvack.org,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Joerg Roedel <jroedel@suse.de>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        "H. Peter Anvin" <hpa@zytor.com>, Ard Biesheuvel <ardb@kernel.org>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Sean Christopherson <seanjc@google.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Jim Mattson <jmattson@google.com>,
        Andy Lutomirski <luto@kernel.org>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Sergio Lopez <slp@redhat.com>, Peter Gonda <pgonda@google.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
        David Rientjes <rientjes@google.com>,
        Dov Murik <dovmurik@linux.ibm.com>,
        Tobin Feldman-Fitzthum <tobin@ibm.com>,
        Borislav Petkov <bp@alien8.de>,
        Michael Roth <michael.roth@amd.com>,
        Vlastimil Babka <vbabka@suse.cz>,
        "Kirill A . Shutemov" <kirill@shutemov.name>,
        Andi Kleen <ak@linux.intel.com>,
        "Dr . David Alan Gilbert" <dgilbert@redhat.com>,
        tony.luck@intel.com, marcorr@google.com,
        sathyanarayanan.kuppuswamy@linux.intel.com
Subject: Re: [PATCH v8 10/40] x86/compressed: Register GHCB memory when
 SEV-SNP is active
Message-ID: <YdNUXlkHlsVeLfr3@dt>
References: <20211210154332.11526-1-brijesh.singh@amd.com>
 <20211210154332.11526-11-brijesh.singh@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211210154332.11526-11-brijesh.singh@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?yXfst024cLKAHhA/fbsFFUlajVvkfWf3Ucv8QUA/lBTNsxNiTqd8Dy1Ru2of?=
 =?us-ascii?Q?2S1zRraywo4jdOMEv6OEbaF5G4I+1RwU4TWy0FliO9UFvZeNWhgAdrBsI2jy?=
 =?us-ascii?Q?QkhHcDg6fGTlj9bbt602DdjQAX1F5kwTYC1zOACtoJPn/cDTSgol1aSR3cR1?=
 =?us-ascii?Q?7tJfSLRlqSWEk6EkZkgqZ2ZIL/3TLyym7CsoZG6YK4xt/2clafjFxCuyRLdl?=
 =?us-ascii?Q?5oraBmDwGvZYeERcjt71YtOCX8nwf3Rg3zy83SZJ6IJurw1CfBUHKQ9rZ+q/?=
 =?us-ascii?Q?VIP7gc4XKQ53twGMNNcMD4i5IGa/n/ZXnTUrkn+jbuHuzdDMZg32wl+e/nBF?=
 =?us-ascii?Q?m+ayrW50IqSsK+QJtCnIZV5QT11gSPQjm4a4PC16j0Zd8hKi/JBuWJyUgg6p?=
 =?us-ascii?Q?heTYGsjRsHy5XVnLNmCmf1Oj8NgK5fiPJvEpGJ1xT13nJN0d6BOrsXGNm6DQ?=
 =?us-ascii?Q?fVCcXNJXXMP23AB0MR9f4IoPotw3dTdOTLfRJmpOK5asmSVcxx4JridzKAr1?=
 =?us-ascii?Q?8m2j1Rdouac5nrW7v9vWhFvVz3G4bE8XscZte5HMx9lLmpBZefjmF82LrcMu?=
 =?us-ascii?Q?uqI788wF/iPMun/QOgTA+xfdR+mskqfC+FbBibSWlB2nqgIh7CfVxek3uLwt?=
 =?us-ascii?Q?M/2yMZ03FL+1xajFyGL0vmJ/FjagUr2nE/Vv54axwqDjDW4TMC4p++iMozfB?=
 =?us-ascii?Q?SzgehEy545JLxB7l07fMR6LxTWVIbqINETFfbxfprURvVJtcjkpedt5GTHSv?=
 =?us-ascii?Q?YQ0ay5VvBrf91YY4AUTaqdqTUasMUxmolXhNkITLgoA0IzYAyY8GLXFuvhs2?=
 =?us-ascii?Q?gezLssgCWxyTYn5LNsvi7cd9b5VnW09cpZvmzz4iWq9RoqHbST33en0S0bdX?=
 =?us-ascii?Q?fYOXGhkNL9VRJCh9ZFKJClhGRGcvm+8EcTnKX04JVm/DYsMsK6tQ/T7kN7EW?=
 =?us-ascii?Q?iUThiKZGtAbPPVBkUJQTH33ekIWUSjvDBFc3fcI1w+1mXPXQUk4pGe3J8Ucx?=
 =?us-ascii?Q?52aArYB7axdFQv1Xt36v5Vsh5MObVZJK8RZXXNg8Kl1e76hGb6MpKOaP6aee?=
 =?us-ascii?Q?fZB83aZ2Q0iVx9eHC6KcLCaWl3RhU0AJ/BGzk/lnxXqDUFsHG08kmXWu68Y/?=
 =?us-ascii?Q?H3dkfHJd528yk4NkPdEYlFJerIgeIG9VREY0gm5QY7xUe8oyCadjn9L7s1KH?=
 =?us-ascii?Q?PVNHl6k0k2tksCXAcpeEuBEXczTS0tnFX5J7AVoEOnhLOINx2q3Y1HY0hkQH?=
 =?us-ascii?Q?pjFg630BdwtJH3RyqoHGZ7c2ONsYiITFzYEnaxdCOEMj29l4nt0XQEAdXsY5?=
 =?us-ascii?Q?dDxv098kk5VAxFnurSJ0GrpZVHrxnq6VR08o6hlpO0Cr9U/cji7EWiBobXY/?=
 =?us-ascii?Q?hi2tgXlrwoPRGFLAjNG2Q+lDWd6+efbK4trWWEjQfbPfqCvq3YIJJH4PDobx?=
 =?us-ascii?Q?r/Pa2Bv32W8+6wv4frTSUTZr00ms/zmtTM8DZRT9l62izYHBuqHNu7AnCa4a?=
 =?us-ascii?Q?bMz9wHgKa8Yk9hCg9PtA4V/a8cCovTwc3vvp9bq1acXdZxubVL8EGHs6h11B?=
 =?us-ascii?Q?tDYye4f/pbhoY1UnbaTOeQvw8EqQ6mg8wsR76wWpdBRGHHJ+hdOaY5Cj3Kr5?=
 =?us-ascii?Q?IDVjKvGQJl11jRqOoLMjP8s1gDa/tV8msJK7gaKEYSeZhcJr9F3WGYfEDgMx?=
 =?us-ascii?Q?LY968Q=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 18105cba-1aeb-4ef0-90d5-08d9cef2d1b9
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB2576.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jan 2022 19:54:14.6712
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vw0fQQDezJrayk2knOZPqJlMdR+2mDwxvCYBq+1FEQ2nA8dRWSdIsUlsLHnHQrdzEV5/tnIBS8PbK2VQ9cszypTqVsS8pcXTaedpy6bTjVI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR10MB3024
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10216 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxlogscore=999 mlxscore=0
 suspectscore=0 spamscore=0 phishscore=0 malwarescore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2201030135
X-Proofpoint-GUID: OfcnqTJEstr-2enLeDr4HdwKnWRaBltv
X-Proofpoint-ORIG-GUID: OfcnqTJEstr-2enLeDr4HdwKnWRaBltv
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2021-12-10 09:43:02 -0600, Brijesh Singh wrote:
> The SEV-SNP guest is required by the GHCB spec to register the GHCB's
> Guest Physical Address (GPA). This is because the hypervisor may prefer
> that a guest use a consistent and/or specific GPA for the GHCB associated
> with a vCPU. For more information, see the GHCB specification section
> "GHCB GPA Registration".
> 
> If hypervisor can not work with the guest provided GPA then terminate the
> guest boot.
> 
> Signed-off-by: Brijesh Singh <brijesh.singh@amd.com>

Reviewed-by: Venu Busireddy <venu.busireddy@oracle.com>

> ---
>  arch/x86/boot/compressed/sev.c    |  4 ++++
>  arch/x86/include/asm/sev-common.h | 13 +++++++++++++
>  arch/x86/kernel/sev-shared.c      | 16 ++++++++++++++++
>  3 files changed, 33 insertions(+)
>