User-Agent: Cyrus-JMAP/3.5.0-alpha0-4525-g8883000b21-fm-20211221.001-g8883000b
Mime-Version: 1.0
Message-Id: <55b214dc-315d-4157-9a69-89241a846898@www.fastmail.com>
In-Reply-To: <20211126015216.26605-1-zhangqing@loongson.cn>
References: <20211126015216.26605-1-zhangqing@loongson.cn>
Date:   Mon, 03 Jan 2022 19:58:24 +0000
From:   "Jiaxun Yang" <jiaxun.yang@flygoat.com>
To:     "Qing Zhang" <zhangqing@loongson.cn>,
        "Rob Herring" <robh+dt@kernel.org>,
        "Thomas Bogendoerfer" <tsbogend@alpha.franken.de>
Cc:     devicetree@vger.kernel.org,
        "linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v9 1/3] MIPS: Loongson64: Add Loongson-2K1000 reset platform driver
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk


=E5=9C=A82021=E5=B9=B411=E6=9C=8826=E6=97=A5=E5=8D=81=E4=B8=80=E6=9C=88 =
=E4=B8=8A=E5=8D=881:52=EF=BC=8CQing Zhang=E5=86=99=E9=81=93=EF=BC=9A
> Add power management register operations to support reboot and powerof=
f.
>
> Signed-off-by: Qing Zhang <zhangqing@loongson.cn>
> ---
> v8-v9:
> No change
> ---
>  drivers/platform/mips/Kconfig      |  6 ++++
>  drivers/platform/mips/Makefile     |  1 +
>  drivers/platform/mips/ls2k-reset.c | 53 ++++++++++++++++++++++++++++++
>  3 files changed, 60 insertions(+)
>  create mode 100644 drivers/platform/mips/ls2k-reset.c
>
> diff --git a/drivers/platform/mips/Kconfig b/drivers/platform/mips/Kco=
nfig
> index 8ac149173c64b..d421e14823957 100644
> --- a/drivers/platform/mips/Kconfig
> +++ b/drivers/platform/mips/Kconfig
> @@ -30,4 +30,10 @@ config RS780E_ACPI
>  	help
>  	  Loongson RS780E PCH ACPI Controller driver.
>=20
> +config LS2K_RESET
> +	bool "Loongson-2K1000 Reset Controller"
> +	depends on MACH_LOONGSON64 || COMPILE_TEST
> +	help
> +	  Loongson-2K1000 Reset Controller driver.
> +
>  endif # MIPS_PLATFORM_DEVICES
> diff --git a/drivers/platform/mips/Makefile=20
> b/drivers/platform/mips/Makefile
> index 1781490987773..4c71444e453a6 100644
> --- a/drivers/platform/mips/Makefile
> +++ b/drivers/platform/mips/Makefile
> @@ -1,3 +1,4 @@
>  # SPDX-License-Identifier: GPL-2.0-only
>  obj-$(CONFIG_CPU_HWMON) +=3D cpu_hwmon.o
>  obj-$(CONFIG_RS780E_ACPI) +=3D rs780e-acpi.o
> +obj-$(CONFIG_LS2K_RESET) +=3D ls2k-reset.o
> diff --git a/drivers/platform/mips/ls2k-reset.c=20
> b/drivers/platform/mips/ls2k-reset.c
> new file mode 100644
> index 0000000000000..b70e7b8a092c2
> --- /dev/null
> +++ b/drivers/platform/mips/ls2k-reset.c
> @@ -0,0 +1,53 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + *  Copyright (C) 2021, Qing Zhang <zhangqing@loongson.cn>
> + *  Loongson-2K1000 reset support
> + */
> +
> +#include <linux/of_address.h>
> +#include <linux/pm.h>
> +#include <asm/reboot.h>
> +
> +#define	PM1_STS		0x0c /* Power Management 1 Status Register */
> +#define	PM1_CNT		0x14 /* Power Management 1 Control Register */
> +#define	RST_CNT		0x30 /* Reset Control Register */
> +
> +static void __iomem *base;
> +
> +static void ls2k_restart(char *command)
> +{
> +	writel(0x1, base + RST_CNT);
> +}
> +
> +static void ls2k_poweroff(void)
> +{
> +	/* Clear */
> +	writel((readl(base + PM1_STS) & 0xffffffff), base + PM1_STS);
> +	/* Sleep Enable | Soft Off*/
> +	writel(GENMASK(12, 10) | BIT(13), base + PM1_CNT);
> +}
> +
> +static int ls2k_reset_init(void)
> +{
> +	struct device_node *np;
> +
> +	np =3D of_find_compatible_node(NULL, NULL, "loongson,ls2k-pm");
> +	if (!np) {
> +		pr_info("Failed to get PM node\n");
> +		return -ENODEV;

Hi Qing,

Could you please remove this print.
Otherwise we will have this suspecious log all loongson64 system, not on=
ly ls2k.

Thanks.

- Jiaxun

> +	}
> +
> +	base =3D of_iomap(np, 0);
> +	if (!base) {
> +		pr_info("Failed to map PM register base address\n");
> +		return -ENOMEM;
> +	}
> +
> +	_machine_restart =3D ls2k_restart;
> +	pm_power_off =3D ls2k_poweroff;
> +
> +	of_node_put(np);
> +	return 0;
> +}
> +
> +arch_initcall(ls2k_reset_init);
> --=20
> 2.31.0

--=20
- Jiaxun