From:   Song Liu <songliubraving@fb.com>
To:     Linus Torvalds <torvalds@linux-foundation.org>
CC:     Norbert Warmuth <nwarmuth@t-online.de>,
        Jens Axboe <axboe@kernel.dk>,
        Guoqing Jiang <guoqing.jiang@linux.dev>,
        "linux-raid@vger.kernel.org" <linux-raid@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [Regression] md/raid1: write-intent logging/bitmap issue since
 fd3b6975e9c1 - v5.16-rc1
Thread-Topic: [Regression] md/raid1: write-intent logging/bitmap issue since
 fd3b6975e9c1 - v5.16-rc1
Thread-Index: AQHYANhvwyU+bNCYN02TTWmpx5kZnaxRtWoAgAAjOQA=
Date:   Mon, 3 Jan 2022 21:59:25 +0000
Message-ID: <D0600716-A336-4622-9A99-6EC4BA4D3B58@fb.com>
References: <m3tuekbos5.fsf@nogrod.ivcecceob.t-online.de>
 <CAHk-=whzdxBuoeTP1uJrxRQYtwOxPDYuP92c8e=_K5T1xHy7Ug@mail.gmail.com>
In-Reply-To: <CAHk-=whzdxBuoeTP1uJrxRQYtwOxPDYuP92c8e=_K5T1xHy7Ug@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?qXCx0DTaupvvXWWOY6Jd5J41UOx5r1iFqzIb+dy57x4d6bGcm5SWDuz5PvNe?=
 =?us-ascii?Q?byYSh7OQSEoOptAb5lidBuvbgH80vohUJX4RcCBw8UUPB4iqZbzLXnCdPFrq?=
 =?us-ascii?Q?5xyAzRzDlofy9k8b/4mUVRUop+WiGW9Wu1889hsSaKvOLTGEQcLTHw75X/IK?=
 =?us-ascii?Q?q4kaNctljzVYacjpL+orL0e4+npk5Da5O4ibcicZkRPY2qgRSmqViTNTBsaG?=
 =?us-ascii?Q?t4EJdkkHJBC+LqvPdb9I2vZEwNYGluesMTeX4xmRAnGBQoivo/n1sNxMshi3?=
 =?us-ascii?Q?qJd58mlMCnaXPX8mxMjteqIhcj5GC1S4mSyOsw4eAwNUbG3nAGvDMbihMf1/?=
 =?us-ascii?Q?gPSlGBSTVLUwqMC3Lu2Vgpexl/9AY28n4UTS+qUXbKk8QMOCPQvuiTRG6+kg?=
 =?us-ascii?Q?UQskuOS1SbZLB14W0V2SRme2xskySzPQyCLV/hdrX5jNze0c9Z72QmfGDUmh?=
 =?us-ascii?Q?xsYieUFf/xoVzAiWX8PPycp40ELQCh3hhLuTZ3aygP45iHeI0mRRjOr9Rm1a?=
 =?us-ascii?Q?sWRL1FF5LlLxtoAfCsUGYqH7h3lnH40JRVkhDWiZdXSC9ksqYIjIartV08T7?=
 =?us-ascii?Q?mHMrrM1JB+AUE/iPicdlzlNtIhWKlgQbN7hr73jHP4fCKn+HKpFpd1srYzT3?=
 =?us-ascii?Q?ZbxV9hcwIJc71/XzbGI2t0yBCCXnason85WpHbRbhnpWWyjDLr6mlom54wrg?=
 =?us-ascii?Q?hDLXJ93jsRqnOgRDUGLYGk2DbuN7CGgfvtIr/x5I06TwpOhUSupDiL4poE/r?=
 =?us-ascii?Q?HUaNwhxFST+ggD1VJdpQuu75o+p++MFsGu1sjzF6RkA6K07kDsrFhpv3i1s7?=
 =?us-ascii?Q?UmRTsAl/k0ZvlSwxqzvxA2n9x7IW0rGYIeIBDuyaKD3Il7yDUcq5DTPFyUL8?=
 =?us-ascii?Q?AaV29ZF/DP5Wb2hqw76VSDj4XF5Y8K3uBZuG8O2ta+VIO4nmdJUJ7CJ7uvo5?=
 =?us-ascii?Q?3WDDsX+4aWgUESJ8HTF6M/9BIILohkWx6c0zvn7Jai+R6cXa4P6Yr7gWUmYx?=
 =?us-ascii?Q?OtDcpFRd96zDewVfqicizuY/MgdEYtvrOb/WSKliZCMNbHQfCm/BZliGwefT?=
 =?us-ascii?Q?2adFPfrFG68VGetMK7zmcKccio6zWFvdpg4WspFNJXEHC7nu1pnpoK/9Ovzz?=
 =?us-ascii?Q?IJJ1K7UFWPhFE8KFQZVdToVOTnf5wBZHZiCGAwbzVGhKfi2NmT6wXFBPuXlw?=
 =?us-ascii?Q?hzS5e64n01/5RTPP9M7Vc2PrLSbjpIGYoTMAnlIl0+2x7Va3GqsQttMzuuMc?=
 =?us-ascii?Q?78sH9Rln0EqyXy/DHKYuocXsXVeiHgfKCZrGAZDcAk+3kNeBe0pVIBdlScW+?=
 =?us-ascii?Q?C05JENiPYRMSFn+VL7dVh5tNwhEXTr6UKW0dyACCybnp3GRP3YK7pFEjBaak?=
 =?us-ascii?Q?38xqiVT5KYrC/PmRIbTRRKW91WarLLpRwMoefVh9wqzYH9urIrK3/lRXvt4B?=
 =?us-ascii?Q?AEs+8uZilHqG/f5j1A88bGSFVAJA2vAHQD9//IM+0Qtj4hq/0pQbNhe0RMqe?=
 =?us-ascii?Q?2R9aZqIzsaWQnZPXmG5zadNctouuNdmBA4+GIW9qkYGwFYn0GUGhOzsPsmCk?=
 =?us-ascii?Q?3cnH1O6RaatLwbuHsXXTD21nljkUZMYi8e76aUBEuGko2KG8/8Yh1Gy190yK?=
 =?us-ascii?Q?+Ee6gWK1c1pu6gIJuoeCgKszJckwBheN/pVT9SgMtqpVJQbixt8XiDMzDlM3?=
 =?us-ascii?Q?LskQPg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <D4F04C90A76E964FA2DDF59476368668@namprd15.prod.outlook.com>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SA1PR15MB5109.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a7fa4ac9-b3e2-4c30-0880-08d9cf044ed0
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Jan 2022 21:59:25.7617
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 4HHmmlr0RYjGYYfme+Z1hZcrakiZTFilDu0alyZZ2lIX9oT+IhNzm7+w6e8MbdbPPbsK7dU3o1KwbDMdQBgJWQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR15MB5096
X-OriginatorOrg: fb.com
X-Proofpoint-ORIG-GUID: 6q9j1MpVfzzXcSNVmvlsM_YtkrEk_haN
X-Proofpoint-GUID: 6q9j1MpVfzzXcSNVmvlsM_YtkrEk_haN
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-01-03_09,2022-01-01_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=fb_outbound_notspam policy=fb_outbound score=0 clxscore=1015
 bulkscore=0 priorityscore=1501 suspectscore=0 adultscore=0 phishscore=0
 lowpriorityscore=0 malwarescore=0 mlxlogscore=999 impostorscore=0
 spamscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2201030148
X-FB-Internal: deliver
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Jan 3, 2022, at 11:53 AM, Linus Torvalds <torvalds@linux-foundation.org> wrote:
> 
> [ Jens wasn't cc'd for some reason but was the signer-off-on the patch
> you bisected to. Added him to the cc. I'll bounce the original
> separately, as I also don't see this on lore.kernel.org - it might not
> have gotten there yet ]
> 
> On Mon, Jan 3, 2022 at 11:30 AM Norbert Warmuth <nwarmuth@t-online.de> wrote:
>> 
>> Please verify and either revert or fixup fd3b6975e9c1 if my analysis is
>> correct.
> 
> Can you check if moving the WriteMostly bit to the "do behind I/O?"
> section fixes things for you?
> 
> IOW, something like the attached patch..
> 
> Warning: This is very much a "Money see, monkey do" patch. I'm not
> really familiar with the raid1 code ]
> 
> But yeah, if you see corruption and there isn't an absolutely trivial
> fix for this, we should revert.
> 
>           Linus
> <patch.diff>

I can confirm this patch fixes the issue. I will send pull request with 
the fix shortly. 

Thanks,
Song