Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933000AbXA2Weo (ORCPT ); Mon, 29 Jan 2007 17:34:44 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932937AbXA2Wen (ORCPT ); Mon, 29 Jan 2007 17:34:43 -0500 Received: from mx1.redhat.com ([66.187.233.31]:56421 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932941AbXA2Wem (ORCPT ); Mon, 29 Jan 2007 17:34:42 -0500 Date: Mon, 29 Jan 2007 17:34:28 -0500 From: Dave Jones To: =?iso-8859-1?Q?Fr=E9d=E9ric?= Riss Cc: Pavel Machek , andi@lisas.de, davej@codemonkey.org.uk, kernel list , seife@suse.de, Wang Zhenyu Subject: Re: i965 testers wanted (Re: intel-agp PM experiences) Message-ID: <20070129223428.GL9363@redhat.com> Mail-Followup-To: Dave Jones , =?iso-8859-1?Q?Fr=E9d=E9ric?= Riss , Pavel Machek , andi@lisas.de, davej@codemonkey.org.uk, kernel list , seife@suse.de, Wang Zhenyu References: <20070117004012.GA11140@rhlx01.hs-esslingen.de> <20070117005755.GB6270@elf.ucw.cz> <20070118115105.GA28233@rhlx01.hs-esslingen.de> <20070118231650.GA5352@ucw.cz> <20070122044519.GA24398@zhen-devel.sh.intel.com> <20070123094456.GG6033@ucw.cz> <1170108330.21603.5.camel@funkylaptop> <20070129221006.GC17199@elf.ucw.cz> <1170109291.21603.15.camel@funkylaptop> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1170109291.21603.15.camel@funkylaptop> User-Agent: Mutt/1.4.2.2i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1962 Lines: 47 On Mon, Jan 29, 2007 at 11:21:31PM +0100, Fr?d?ric Riss wrote: > Le lundi 29 janvier 2007 ? 23:10 +0100, Pavel Machek a ?crit : > > > > Ok, I guess we'd like some testing here... so that in can be fixed in > > > > mainline... > > > > > > I can confirm that this patch is needed for my Intel Mac Mini to resume > > > correctly when used without BIOS emulation (EFI mode). Here're the > > > relevant lspci lines: > > > > Can you attach the patch you tested (there was link above, but it did > > not work for me), and try pushing it through maintainers? > > I inlined the patch I used below. If I'm not mistaken, the maintainer is > Davej which is already in the Cc: list. I think it's exactly the same as > was submitted in http://lkml.org/lkml/2007/1/16/297 (I may have hand > copied it though, can't remember). The above link is more complete as it > contains the Signed-off-by and a description. > > diff --git a/drivers/char/agp/intel-agp.c b/drivers/char/agp/intel-agp.c > index ab0a9c0..f64a115 100644 > --- a/drivers/char/agp/intel-agp.c > +++ b/drivers/char/agp/intel-agp.c > @@ -1955,6 +1955,15 @@ static int agp_intel_resume(struct pci_d > > pci_restore_state(pdev); > > + /* We should restore our graphics device's config space, > + * as host bridge (00:00) resumes before graphics device (02:00), > + * then our access to its pci space can work right. > + */ > + if (intel_i810_private.i810_dev) > + pci_restore_state(intel_i810_private.i810_dev); > + if (intel_i830_private.i830_dev) > + pci_restore_state(intel_i830_private.i830_dev); This has been in agpgart.git since the 17th. I asked Linus to pull last night. Dave -- http://www.codemonkey.org.uk - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/