Date:   Mon, 3 Jan 2022 17:35:11 -0800
From:   "Darrick J. Wong" <djwong@kernel.org>
To:     Dave Chinner <david@fromorbit.com>
Cc:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
        linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org,
        Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH] net/tls: Remove redundant initialization of mp
Message-ID: <20220104013511.GC31583@magnolia>
References: <20211231122352.14275-1-jiapeng.chong@linux.alibaba.com>
 <20220101035716.GF945095@dread.disaster.area>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220101035716.GF945095@dread.disaster.area>
Precedence: bulk

On Sat, Jan 01, 2022 at 02:57:16PM +1100, Dave Chinner wrote:
> On Fri, Dec 31, 2021 at 08:23:52PM +0800, Jiapeng Chong wrote:
> > mp is being initialized to log->l_mp but this is never read
> > as record is overwritten later on. Remove the redundant
> > initialization.
> 
> The compiler is not smart enough to just elide the second "mp =
> log->l_mp;" assignment?

It is, but it would seem, alas, that people with AIs want to waste both
our time reviewing trivial (and WRONG!) changes generated by automated
tools that duplicate functionality long available in automated tools.

It would be /really awesome/ if these people with giant farms of servers
could instead turn their attention towards finding deeper functionality
bugs and design thinkos in less well tested code paths (like rt and
quota) so that Leah and I aren't the only ones...

> > Cleans up the following clang-analyzer warning:
> > 
> > fs/xfs/xfs_log_recover.c:3543:20: warning: Value stored to 'mp' during
> > its initialization is never read [clang-analyzer-deadcode.DeadStores].
> > 
> > Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> > ---
> >  fs/xfs/xfs_log_recover.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/fs/xfs/xfs_log_recover.c b/fs/xfs/xfs_log_recover.c
> > index 8ecb9a8567b7..9142efbdc670 100644
> > --- a/fs/xfs/xfs_log_recover.c
> > +++ b/fs/xfs/xfs_log_recover.c
> > @@ -3540,7 +3540,7 @@ STATIC void
> >  xlog_recover_check_summary(
> >  	struct xlog		*log)
> >  {
> > -	struct xfs_mount	*mp = log->l_mp;
> > +	struct xfs_mount	*mp;
> >  	struct xfs_perag	*pag;
> >  	struct xfs_buf		*agfbp;
> >  	struct xfs_buf		*agibp;
> 
> You removed the wrong initialisation line. Leave this one here and
> remove the standalone one.

...and fix the subject line, this isn't networking code.

--D

> Cheers,
> 
> Dave.
> -- 
> Dave Chinner
> david@fromorbit.com