Subject: Re: [PATCH 1/1] scripts: sphinx-pre-install: add required ctex
 dependency
From:   Akira Yokosawa <akiyks@gmail.com>
To:     mchehab@kernel.org
Cc:     hch@lst.de, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org, corbet@lwn.net
References: <87mtkcxws9.fsf@meer.lwn.net>
 <eeb773ef-0354-be1f-8438-07e3324fa9f6@gmail.com>
Message-ID: <07f8cf68-525b-4fca-a1f9-fd40150fc6e1@gmail.com>
Date:   Tue, 4 Jan 2022 10:54:52 +0900
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <eeb773ef-0354-be1f-8438-07e3324fa9f6@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Mauro, see inline comments below.

On Tue, 4 Jan 2022 09:04:30 +0900, Akira Yokosawa wrote:
> Hi,
> 
> On Mon, 03 Jan 2022 15:46:30 -0700, Jonathan Corbet <corbet@lwn.net> wrote:
>> Mauro Carvalho Chehab <mchehab@kernel.org> writes:
>>
>>> After a change meant to fix support for oriental characters
>>> (Chinese, Japanese, Korean), ctex stylesheet is now a requirement
>>> for PDF output.
> 
> FWIW, ctexhook.sty is a new requirement of xeCJK.sty v3.8.7 released
> in June 2021.
> 
>         Thanks, Akira
> 
>>>
>>> Reported-by: Christoph Hellwig <hch@lst.de>
>>> Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
>>> ---
>>>
>>> See [PATCH 0/1] at: https://lore.kernel.org/all/cover.1641243581.git.mchehab@kernel.org/
>>>
>>>  scripts/sphinx-pre-install | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/scripts/sphinx-pre-install b/scripts/sphinx-pre-install
>>> index 288e86a9d1e5..46aaab414098 100755
>>> --- a/scripts/sphinx-pre-install
>>> +++ b/scripts/sphinx-pre-install
>>> @@ -78,6 +78,7 @@ my %texlive = (
>>>  	'ucs.sty'            => 'texlive-ucs',
>>>  	'upquote.sty'        => 'texlive-upquote',
>>>  	'wrapfig.sty'        => 'texlive-wrapfig',
>>> +	'ctexhook.sty'       => 'texlive-ctex',
>>>  );
>>

I'm afraid this update of the list for Fedora/openSUSE won't help
Debian Stable (bullseye) users.

ctexhook.sty is in texlive-lang-chinese on Debian/Ubuntu.

        Thanks, Akria


>> I've applied this, thanks.> 
>> jon
> 
>