Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933014AbXA2Wnc (ORCPT ); Mon, 29 Jan 2007 17:43:32 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933021AbXA2Wnc (ORCPT ); Mon, 29 Jan 2007 17:43:32 -0500 Received: from smtp.osdl.org ([65.172.181.24]:60085 "EHLO smtp.osdl.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933014AbXA2Wnb (ORCPT ); Mon, 29 Jan 2007 17:43:31 -0500 Date: Mon, 29 Jan 2007 14:40:55 -0800 From: Stephen Hemminger To: Linus Torvalds Cc: Thomas Gleixner , Linux Kernel Mailing List , Jeff Garzik Subject: Re: Linux 2.6.20-rc6 - sky2 resume breakage Message-ID: <20070129144055.151cfe52@freekitty> In-Reply-To: References: <1169931333.17469.125.camel@localhost.localdomain> <20070129113159.7ad22e4c@freekitty> <1170101430.29240.34.camel@localhost.localdomain> <20070129133849.1b523226@freekitty> <1170109401.29240.49.camel@localhost.localdomain> Organization: Linux Foundation X-Mailer: Sylpheed-Claws 2.5.0-rc3 (GTK+ 2.10.6; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1729 Lines: 43 On Mon, 29 Jan 2007 14:37:23 -0800 (PST) Linus Torvalds wrote: > > > On Mon, 29 Jan 2007, Thomas Gleixner wrote: > > > > Reverting commit 44ade178249fe53d055fd92113eaa271e06acddd, which added > > this hackery in the first place, makes the device survive > > suspend/resume. > > I suspect some BIOSes do *not* screw up the MSI thing on resume, and > others do. > > I would suggest that the real fix is to not do that kind of hackery at > suspend/resume time (because we can't know what the heck the BIOS does), > and instead just do one of two cases: > > - since MSI is known to be broken for the sky2 driver due to firmware > bugs, just disable it by default if CONFIG_PM is enabled. The > advantages of MSI just aren't all that compelling. Possibly add a > command line option to force MSI to be enabled regardless. MSI works fine for almost all systems (except AMD systems where MSI is broken for ALL devices). > Simple, direct, and should work for everybody. > > - Just add a command line to disable MSI for people that it breaks for. > > I don't actually like this one. It defaults to the unsafe behaviour, > and while that makes sense in a "well, your machine is broken anyway" > kind of way, the thing is, the advantages of MSI just aren't big enough > to warrant defaulting to a known-unsafe thing, even if only a small > percentage of machines are affected. Module option out already exists. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/