From:   Saurav Kashyap <skashyap@marvell.com>
To:     Jiasheng Jiang <jiasheng@iscas.ac.cn>,
        Javed Hasan <jhasan@marvell.com>,
        GR-QLogic-Storage-Upstream <GR-QLogic-Storage-Upstream@marvell.com>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "linux@armlinux.org.uk" <linux@armlinux.org.uk>
CC:     "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: RE: [EXT] [PATCH] scsi: qedf: potential dereference of null pointer
Thread-Topic: [EXT] [PATCH] scsi: qedf: potential dereference of null pointer
Thread-Index: AQHX8mXGRWO7SF21CECbm2a/GitlN6xSW43w
Date:   Tue, 4 Jan 2022 04:05:15 +0000
Message-ID: <DM6PR18MB3034EC46365E384336A44E53D24A9@DM6PR18MB3034.namprd18.prod.outlook.com>
References: <20211216101449.375953-1-jiasheng@iscas.ac.cn>
In-Reply-To: <20211216101449.375953-1-jiasheng@iscas.ac.cn>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?+fYHLEZ4QWT/Btjh5+5AhUJ3laPk0GF1tDFmtnUDNhy5KEOHN/RvPZFxdmch?=
 =?us-ascii?Q?TWMJ5aIJCwKz8LXeRaRh8fOn5BwDx0n9izuZZ09PKo5yYubosnqCL12tVB73?=
 =?us-ascii?Q?5186Dlb/PA9ob8ntNYqokkoi54GXzRqRu2tTVF6BazRtyDTaDG4IHcVGP06+?=
 =?us-ascii?Q?Eu0t+0yrsjhzFXfWbQqlAFEgLilPORA7D8AAWLc9i7aYExRKjGRAYcxpPaWM?=
 =?us-ascii?Q?oNEfL7+ghKgZCtfhmjyk/s5Ki2GVENsYZ2vWxMNj1Z7GcYY7wP02XLTia9lg?=
 =?us-ascii?Q?2tNcZXg2dcqOAkiGPRii6KGl1Yha83G00jseR/i3r7feXyEgOGL2jZkuFfaz?=
 =?us-ascii?Q?BHbXLtjBzOoLBbXIaCX850zj3EZpYfzsTJEErX9sUo9JyhXNQkNP8ZbHMIJh?=
 =?us-ascii?Q?Z7iaUKpv82yeigp5CR8VHIafhdJW8ZhwPgzQaEKL6PSb8GteBOZ29e8cV9/t?=
 =?us-ascii?Q?OTfnSunXMBaTZ0Cg3AzrrkICIv143hrRzovKnre0KK9hPYQn8KRD6W/4+gK3?=
 =?us-ascii?Q?YmN+FNsAz2gErg2O2JfgL8P2PnCOOUvSOrevYE+SdMhgk5lwDcRwtDbaASsU?=
 =?us-ascii?Q?2S/nkBIizlPEIhMIDLcmYQuUNJPpLPlC215E9429fx1qXZxU/bc4lxck48Al?=
 =?us-ascii?Q?OJ+phI0WYS2Id4tn/fJ+DvYxl2ZIDboMJdf51lD1YKg/vdGw0LymxNoBEvB2?=
 =?us-ascii?Q?NcXiMa6Hm5yXvPpWMAHf21OeeSvNlu/x4s+HO2rAYumqrwxuRmoUXSzG1qT0?=
 =?us-ascii?Q?uHXHP+d6Txjcjdu4TJYnArA+RqVbzNlRqk9JCbrnVF6Bc3kg5Rznim8Fjt4w?=
 =?us-ascii?Q?j8LCutTZRE33nGRt028GvTdbkUC3xTe8a+c6HC+JhoM00jmJiXqfJBy+vSzw?=
 =?us-ascii?Q?lf060oFhlKac2o8vGXK1OMv8jvhYfyb6yRsHL3NOR6uEvHuHWLSo2A9AZde6?=
 =?us-ascii?Q?uvv4bU9jKp935Ft/PngMIs2Cg5k5fKl7OSOCednKQ8Qx9FsgtHehiuJuxR6Y?=
 =?us-ascii?Q?c96Ltor20csG3Y6ar70ch/IfRFyRu1xdrOIdjSk1xibhZeVxXof17Ay7oZ3R?=
 =?us-ascii?Q?FedYCIJjfyQWU6QppiTXm/hck8lHEH0JqCYb2FiH3GjlOy4Ho2qVFzfvdyW0?=
 =?us-ascii?Q?ujsccaWKO/OWoWXvigB1i7rjUCjI9LXSgrrD4dL5c46afMikiScvIwUzPXGQ?=
 =?us-ascii?Q?g4ZKQtV5wPRFv4EScj/yegke4ZF0KNq+QgXd+oPsrfUWPrYTm/nDfoEjnfiG?=
 =?us-ascii?Q?DxUDiCLncNPyNqywza822mjvipWdfRDmWMPzPUaM9dgzaPW3kQexzOxG8/d2?=
 =?us-ascii?Q?amOSwfx4Za3092hhLLeCym/vEPKC39unzHbV7EaJHJ5xQo69ptsZI/Cp6+Fc?=
 =?us-ascii?Q?Or20GbgubMHnpKMX87T9UoVtpRPUhMQzlME402Aiirroy1jLvVfqaAq3/R4z?=
 =?us-ascii?Q?rlhDBtB5AnN7BJd41OOyQ3n2Fi8nFp0+L2ryJLSjPmkaAdwujuLnT3t2P10O?=
 =?us-ascii?Q?8h15eFVT7VYkqZzzUj+M7pzSrQARPB3OquTJ8esdQyLAVxK+JBecz3OWPRkI?=
 =?us-ascii?Q?an0ljnRkFK71dzGCTrNXu3CX7jLrRu8KT1/zx5RgETiUmBr3wYmm4obwXARU?=
 =?us-ascii?Q?e+2CC9/iI/2Pe3gSIce9fAY=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR18MB3034.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 98d75292-15b8-4b6c-8cd0-08d9cf3769c1
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Jan 2022 04:05:15.3141
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: SwdD8Ctpx4SSemc1/ayb7v7/5jsFAubFvAqwzU0XwDGf8EtUt4sQjvbrReqjCrR1l3FF9r6MDvK/H+w6yM5kKw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR18MB3258
X-Proofpoint-ORIG-GUID: dTYy4ZwNZLk_fMT_CpY2BNCl4ha30sGm
X-Proofpoint-GUID: GrYGXNqBIAvssZXSmq2JkT_w3wwgzlhk
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-01-04_02,2022-01-01_01,2021-12-02_01
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

HI Jiasheng Jiang,

> -----Original Message-----
> From: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> Sent: Thursday, December 16, 2021 3:45 PM
> To: Saurav Kashyap <skashyap@marvell.com>; Javed Hasan
> <jhasan@marvell.com>; GR-QLogic-Storage-Upstream <GR-QLogic-Storage-
> Upstream@marvell.com>; jejb@linux.ibm.com; martin.petersen@oracle.com;
> linux@armlinux.org.uk
> Cc: linux-scsi@vger.kernel.org; linux-kernel@vger.kernel.org;
> netdev@vger.kernel.org; Jiasheng Jiang <jiasheng@iscas.ac.cn>
> Subject: [EXT] [PATCH] scsi: qedf: potential dereference of null pointer
>=20
> External Email
>=20
> ----------------------------------------------------------------------
> The return value of dma_alloc_coherent() needs to be checked.
> To avoid use of null pointer in case of the failure of alloc.
>=20
> Fixes: 61d8658b4a43 ("scsi: qedf: Add QLogic FastLinQ offload FCoE driver
> framework.")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> ---
>  drivers/scsi/qedf/qedf_main.c | 2 ++
>  1 file changed, 2 insertions(+)
>=20
> diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.=
c
> index b92570a7c309..309e205a8e70 100644
> --- a/drivers/scsi/qedf/qedf_main.c
> +++ b/drivers/scsi/qedf/qedf_main.c
> @@ -1415,6 +1415,8 @@ static void qedf_upload_connection(struct qedf_ctx
> *qedf,
>  	 */
>  	term_params =3D dma_alloc_coherent(&qedf->pdev->dev,
> QEDF_TERM_BUFF_SIZE,
>  		&term_params_dma, GFP_KERNEL);
> +	if (!term_params)
> +		return;
>=20
>  	QEDF_INFO(&(qedf->dbg_ctx), QEDF_LOG_CONN, "Uploading
> connection "
>  		   "port_id=3D%06x.\n", fcport->rdata->ids.port_id);
> --

Acked-by: Saurav Kashyap <skashyap@marvell.com>

Thanks,
~Saurav
> 2.25.1