Message-ID: <5d4fe1b8-0a70-5fc8-b0ea-48cc709e3c03@oracle.com>
Date:   Tue, 4 Jan 2022 16:48:35 +1100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.1
Subject: Re: [RFC PATCH v2 1/2] kernfs: use kernfs_node specific mutex and
 spinlock.
Content-Language: en-US
From:   Imran Khan <imran.f.khan@oracle.com>
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     tj@kernel.org, linux-kernel@vger.kernel.org
References: <20220103084544.1109829-1-imran.f.khan@oracle.com>
 <20220103084544.1109829-2-imran.f.khan@oracle.com>
 <YdLH6qQNxa11YmRO@kroah.com>
 <719eb5d2-680c-e596-1446-3ca8f47c3aea@oracle.com>
In-Reply-To: <719eb5d2-680c-e596-1446-3ca8f47c3aea@oracle.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S2JVS1Z6RlV5ZGp5eXBJSlBrMnFSdFVzN1FTbGpQTlFIOVhWcGFKdVVVZW5z?=
 =?utf-8?B?Z21ldnhheDNtL0c0RkVXMzl2cnJhOVhoWm9kMEk5SEd5S2FiVVNmTWNXNFRX?=
 =?utf-8?B?K2dOeWFyREZlVzZpZ3VKZExBSDhwNzhFM3dPZlpLMHhWd2ZTV3BQQnhvMlRX?=
 =?utf-8?B?aURJWGIwQXNLY3ZhanJxYlQza2NCem1sc2tmVkRLWTdIU3NwRkVodDZwb0Vo?=
 =?utf-8?B?bk9lZ2V0WWNVd3U3TVp6SEZJK21QUFdNQUZiTlFiVTdPVm9VbHVsVjNvUTlo?=
 =?utf-8?B?WmNYYXlYcUZOcDQwblpZcW5EeWZmVUpCdDZqSW85ZjVhSkxxUUdsZTRSRFVu?=
 =?utf-8?B?NVJuYk1CRWVIYkVlaWpDbE5ZcE5abGpFQVZQQXlrRk1xRG1ZeWd6NGlBZndq?=
 =?utf-8?B?Vk5VYm41aVppZ0YvSnNFWEY3RWRBQU5FVnkrK2VORzdtU1l0TEZYV3hoYVR0?=
 =?utf-8?B?RkhyelNpSkxsOCt1RUhGczFQNk1CL3BiK0lSZ1Y4ZnNlOUh4dmN1Ynhmc3Fi?=
 =?utf-8?B?bW1BOTE2N0dWbXkvNnpBajlzdmZabXZuNUNJS0tjdEkwTjd1QnZwQ3ZCMC96?=
 =?utf-8?B?WWYzU0ZWVkdhNmpqTTI2RHlzb3pqV0tDaWpYeXRTWUF1OEl3RGZNQXFOdkpD?=
 =?utf-8?B?d0VuMndEVjB1S2JlQ0E3aGtVS0ZjTjZyMzdVQS96RkVRRCtSdWNGYi9Ra3N1?=
 =?utf-8?B?NkEvdHFOREF0eVRaS0tnVk9qRU8zdGRHMWJUamI4RWZCbnBDUzR1SGN6L296?=
 =?utf-8?B?MW9xUlRic1RDMU81M3k2UEZ3N0VMUWZnbDBuZXVRN25VL2tqVWY2K2Zmam9h?=
 =?utf-8?B?cTd6SG5TQkNlZWJWUlJQYnFYS1JtTmV5TjVPTVM2ejZncWo4OW1sM2RJbkFM?=
 =?utf-8?B?TW9KeHRXSm9vbVhmaHpxR3g2eUM2RzdUcmFWK3RDNlMwYVJwZEdCVEJ6all4?=
 =?utf-8?B?elVTVWxoY0FCVHlhWUlrb2NvbmRyRXBVL0Zyd2hwNFVjY291VW5haUc5bXll?=
 =?utf-8?B?NGZGTWk0WjYrY1hxNm1YaVE0bWx4VWdUazJqRUxFS0NaMzkwT0FESXJ5NHBj?=
 =?utf-8?B?c1J5Z1FEQ1l5WitlWEtVYnQ3dGg5Qld3U01wMWlUK3EvNUwvZnNTbjJBdnk4?=
 =?utf-8?B?RnM0K25XQmhmekVob0xlQ0YwR2oxY1RwN2dvMHlLUENlbUFnd0prU2JPcUI3?=
 =?utf-8?B?VWtXcjdvYTBON3dNWjFEWTdLNW1vRGE4Ry9hYVJQRytUUDJHb3JNeVpsbThq?=
 =?utf-8?B?L1UwWS8xdGxrMS9qQXkzRnhqQndwQXNZVXBhOTFET3EyeWRpTGIvWFNGUWFm?=
 =?utf-8?B?NkE3SDlYcXZGVHVMeGV4ZnR0Nk9JZkk5eWFPUWx6Tk5acEdiMmJIdDFlLzZJ?=
 =?utf-8?B?cG1MV3VkcTQwWDg0Z0luNk9TbktaUkpwdWsrNUlyQWtjUGI4dGwrd1Zud0Zw?=
 =?utf-8?B?c1hGbVN4eUhCYjJHdmZMWnRiUUc2dGRya05Ic1dnaFpUNndSYjg2VSs3VUgw?=
 =?utf-8?B?ajBscDdPOGZzVnpyang4bk5nYkExMjRPUkFOOU1YSWIvUTFmQW5xSU4yd0RS?=
 =?utf-8?B?Wm9ucURaM2dRQTY5YnJUaTQ4dWU3aW13b2MzNEJEQnVocWxhb3dsQ29ZYmJo?=
 =?utf-8?B?RHZFajhZb2Vna3NVM29oRHZlT2QxcHJrRTc1UFRJQlpQVEhvcVk3ZC9mUG5u?=
 =?utf-8?B?UDdLVW4vbkxHVkxoYUZjOVEwWkQ1MGRzd0RFYi9uRFo1Q3k5YTh5Mk5SOG9U?=
 =?utf-8?B?eEpmaE5tT3FWamRhMkJtc2hOR2xHYXp5TW16WnJ3YUk3U0k3SDhpNVN4WlpJ?=
 =?utf-8?B?bGJnalJtcFVFTDlNaHk0RngwU3FvVWNyeHpyWTR3cXBkYWN5ZlEyOUJjbll3?=
 =?utf-8?B?anlUaytNYlpkeCsvL012d25pT0kyNCsySHVwYUhwdkk2MzhsSXQ0N1NOL2x1?=
 =?utf-8?B?WXloa3N0UjdNVEFPWEdzZTNMMDlLa1RzUDBjTjl4N2VmeHkvMExvbS9YaGF5?=
 =?utf-8?B?YWZsbncwZm5JTnkvNEFUbGN4SG1kbXZQdFA5dGlHMEdudXU2SUt0ZWdMQ0E4?=
 =?utf-8?B?UXUzck4wTnZwaDFETlhVNVpTQ0pmb0phazdub0pNdytPelRBZHBXOWk5ZThP?=
 =?utf-8?B?NVN2NEd2ZHZQK2RvVXRaZzI4NFJXV3RtdHNFb25lYzFrZEtTc2cyWEttVGVa?=
 =?utf-8?Q?NWo4ia9lgfZ8/2lUndvGXDo=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 03180095-c46b-4b64-c2dd-08d9cf45dc93
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4468.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jan 2022 05:48:41.2198
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BWsHeBt8SX1Rk6udV9x0zEBjzCiCYQaCtw7wBuiHp8WG1zGx/MF0vhj84AHqZLGO1XgCes1kETks36v6N/m16Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1001MB2205
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10216 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxlogscore=960 mlxscore=0
 suspectscore=0 spamscore=0 phishscore=0 malwarescore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2201040039
X-Proofpoint-GUID: TwT2Fs5o6KMR8H1aOfV7kBzxhTAOInC7
X-Proofpoint-ORIG-GUID: TwT2Fs5o6KMR8H1aOfV7kBzxhTAOInC7
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Greg

On 4/1/22 9:16 am, Imran Khan wrote:
> 
> 
> On 3/1/22 8:54 pm, Greg KH wrote:
>> On Mon, Jan 03, 2022 at 07:45:43PM +1100, Imran Khan wrote:
>>> diff --git a/include/linux/kernfs.h b/include/linux/kernfs.h
>>> index 861c4f0f8a29..5ed4c9ed39af 100644
>>> --- a/include/linux/kernfs.h
>>> +++ b/include/linux/kernfs.h
>>> @@ -164,6 +164,8 @@ struct kernfs_node {
>>>  	unsigned short		flags;
>>>  	umode_t			mode;
>>>  	struct kernfs_iattrs	*iattr;
>>> +	spinlock_t kernfs_open_node_lock;
>>> +	struct mutex kernfs_open_file_mutex;
>>
>> Did you just blow up the memory requirements of a system with lots of
>> kobjects created?
>>> We used to be able to support tens of thousands of scsi devices in a
>> 32bit kernel, with this change, what is the memory difference that just
>> happened?
>>
> Indeed, this patch increases kernfs_node size by 36 bytes ( 28 bytes for
> mutex + 4 bytes for spinlock). From current kernfs_node size of 128
> bytes, this will be a ~25% increase in kobjects memory consumption.
> I can replace the mutex object with a pointer to it, to bring down
> the overall increase in size. Will the size change be acceptable then?
> 

Please ignore my proposal about using pointers to mutex object. It will
reduce the size of kernfs_node object but eventually overall kobject
memory usage will not reduce.

Thanks,
Imran